Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildbot updates for Python 3.8 #83962

Open
17 tasks done
boomanaiden154 opened this issue Mar 5, 2024 · 18 comments
Open
17 tasks done

Buildbot updates for Python 3.8 #83962

boomanaiden154 opened this issue Mar 5, 2024 · 18 comments
Labels
infrastructure Bugs about LLVM infrastructure

Comments

@boomanaiden154
Copy link
Contributor

boomanaiden154 commented Mar 5, 2024

Landing #78828 (as a part of https://discourse.llvm.org/t/rfc-upgrading-llvms-minimum-required-python-version/67571) caused failures on the following buildbots:

  1. sanitizer-pcc64be-linux - emailed
  2. libc-x86_64-debian-fullbuild-dbg-asan - @michaelrj-google @lntue @nickdesaulniers
  3. clang-ppc64be-linux-test-suite - emailed
  4. libc-x86_64-debian-gcc-fullbuild-dbg - @michaelrj-google @lntue @nickdesaulniers
  5. polly-arm-linux - emailed
  6. clangd-ubuntu-tsan - @ChristianKuehnel
  7. sanitizer-x86_64-linux-android - @vitalybuka
  8. clang-ppc64le-linux-test-suite - emailed
  9. sanitizer-ppc64le-linux - emailed
  10. ppc64le-lld-multistage-test - emailed
  11. libc-x86_64-debian-dbg-runtimes-build - @michaelrj-google @lntue @nickdesaulniers
  12. libc-x86_64-debian - @michaelrj-google @lntue @nickdesaulniers
  13. libc-x86_64-debian-dbg-asan - @michaelrj-google @lntue @nickdesaulniers
  14. clang-ppc64le-linux-multistage - emailed
  15. libc-x86_64-debian-fullbuild-dbg - @michaelrj-google @lntue @nickdesaulniers
  16. ppc64le-mlir-rhel-clang - emailed
  17. ppc64le-flang-rhel-clang - emailed

These are the buildbots that I saw fail after landing the Python 3.8 upgrade (status page. It's possible there are more failures as I only left the patch in for less than an hour before pulling it, so we'll probably have to do another round of this. I have either pinged buildbot maintainers here or emailed them with a link to this issue so that we can get things moving.

Action needed: Please upgrade the buildbot(s) for which you are a maintainer to Python 3.8 or newer so we can reland the change described in the RFC (and/or add additional context/a timeline on this issue/the discourse RFC thread).

@boomanaiden154 boomanaiden154 added the infrastructure Bugs about LLVM infrastructure label Mar 5, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Mar 5, 2024

@llvm/issue-subscribers-infrastructure

Author: Aiden Grossman (boomanaiden154)

Landing https://github.com//pull/78828 (as a part of https://discourse.llvm.org/t/rfc-upgrading-llvms-minimum-required-python-version/67571) caused failures on the following buildbots: 1. [sanitizer-pcc64be-linux](https://lab.llvm.org/buildbot/#/builders/18/builds/15081) - emailed 2. [libc-x86_64-debian-fullbuild-dbg-asan](https://lab.llvm.org/buildbot/#/builders/162/builds/51187) - @michaelrj-google @lntue @nickdesaulniers 3. [clang-ppc64be-linux-test-suite](https://lab.llvm.org/buildbot/#/builders/231/builds/20820) - emailed 4. [libc-x86_64-debian-gcc-fullbuild-dbg](https://lab.llvm.org/buildbot/#/builders/250/builds/18780) - @michaelrj-google @lntue @nickdesaulniers 5. [polly-arm-linux](https://lab.llvm.org/buildbot/#/builders/56/builds/10516) - emailed 6. [clangd-ubuntu-tsan](https://lab.llvm.org/buildbot/#/builders/131/builds/59442) - @ChristianKuehnel 7. [sanitizer-x86_64-linux-android](https://lab.llvm.org/buildbot/#/builders/77/builds/34771) - @vitalybuka 8. [clang-ppc64le-linux-test-suite](https://lab.llvm.org/buildbot/#/builders/230/builds/25159) - emailed 9. [sanitizer-ppc64le-linux](https://lab.llvm.org/buildbot/#/builders/19/builds/24817) - emailed 10. [ppc64le-lld-multistage-test](https://lab.llvm.org/buildbot/#/builders/36/builds/42792) - emailed 11. [libc-x86_64-debian-dbg-runtimes-build](https://lab.llvm.org/buildbot/#/builders/225/builds/31362) - @michaelrj-google @lntue @nickdesaulniers 12. [libc-x86_64-debian](https://lab.llvm.org/buildbot/#/builders/78/builds/65860) - @michaelrj-google @lntue @nickdesaulniers 13. [libc-x86_64-debian-dbg-asan](https://lab.llvm.org/buildbot/#/builders/73/builds/62872) - @michaelrj-google @lntue @nickdesaulniers 14. [clang-ppc64le-linux-multistage](https://lab.llvm.org/buildbot/#/builders/121/builds/39265) - emailed 15. [libc-x86_64-debian-fullbuild-dbg](https://lab.llvm.org/buildbot/#/builders/163/builds/51774) - @michaelrj-google @lntue @nickdesaulniers 16. [ppc64le-mlir-rhel-clang](https://lab.llvm.org/buildbot/#/builders/88/builds/71503) - emailed 17. [ppc64le-flang-rhel-clang](https://lab.llvm.org/buildbot/#/builders/21/builds/92881) - emailed

These are the buildbots that I saw fail after landing the Python 3.8 upgrade (status page. It's possible there are more failures as I only left the patch in for less than an hour before pulling it, so we'll probably have to do another round of this. I have either pinged buildbot maintainers here or emailed them with a link to this issue so that we can get things moving.

Action needed: Please upgrade the buildbot(s) for which you are a maintainer to Python 3.8 or newer so we can reland the change described in the RFC (and/or add additional context/a timeline on this issue/the discourse RFC thread).

@kadircet
Copy link
Member

kadircet commented Mar 5, 2024

Issue title says 3.10, but I believe that's a typo and this should be 3.8, right?

@boomanaiden154 boomanaiden154 changed the title Buildbot updates for Python 3.10 Buildbot updates for Python 3.8 Mar 5, 2024
@boomanaiden154
Copy link
Contributor Author

Issue title says 3.10, but I believe that's a typo and this should be 3.8, right?

Good point. Updated to reflect that the minimum version is only being bumped to 3.8.

@nickdesaulniers
Copy link
Member

Yesterday I upgraded the libc buildbots from debian 10 to debian 12. They're now running Python 3.11.2.

@vitalybuka
Copy link
Collaborator

CC @fmayer

@fmayer
Copy link
Contributor

fmayer commented Mar 6, 2024

Running update of the Android buildbot to Ubuntu focal (which has Python 3.8)

@fmayer
Copy link
Contributor

fmayer commented Mar 6, 2024

sanitizer-x86_64-linux-android updated:

$ python3 --version
Python 3.8.10

@lei137
Copy link
Contributor

lei137 commented Mar 22, 2024

The PowerPC linux LE and BE bots have been updated to use Python 3.8.18.

@DeinAlptraum
Copy link

Since all boxes on the list are ticked, is there a reason this is still open?
If not, can we repeat #78828 now?

@boomanaiden154
Copy link
Contributor Author

boomanaiden154 commented Apr 19, 2024

Yes. I just realized that someone updated the clangd-ubuntu-tsan bot yesterday. I just need to do the actual push and see if anything else breaks again.

I will probably try and do that today.

boomanaiden154 added a commit that referenced this issue Apr 20, 2024
This reverts commit 2dfa30d.

This relands commit 0a6c74e.

This patch originally caused a host of buildbot failures due to several
buildbots not having the necessary python version. That was tracked in
issue #83962, and all bots that failed in the first round have now been
updated. This is an attempt to reland the patch to see if it sticks or
if there are a number of long-running bots where this patch will cause
failures.
@boomanaiden154
Copy link
Contributor Author

boomanaiden154 commented Apr 20, 2024

I'm going to pull this one more time as the relanding saw a couple bots fail:

Action needed for the people pinged here: Please update the buildbots for which you are listed as a maintainer to Python 3.8 so we can complete the upgrade described in the RFC.

@jplehr
Copy link
Contributor

jplehr commented Apr 20, 2024

Thanks for the ping. When this RFC was active for comments, we did not yet have this SLES bot running, so I missed the discussions, and this change caught me a bit by surprise.

I have updated the bot and triggered a build in https://lab.llvm.org/buildbot/#/builders/285/builds/779 which restored the bot status back to green.

@boomanaiden154
Copy link
Contributor Author

Sorry about that. Thanks for getting a fix pushed so quickly!

boomanaiden154 added a commit that referenced this issue Apr 20, 2024
This reverts commit f293118.

This was again causing buildbot failures. #83962 has been updated with the new
failures, notifying the buildbot maintainers that they need to update their
bots.
@glaubitz
Copy link
Contributor

I'm going to pull this one more time as the relanding saw a couple bots fail:

* [x]  [openmp-offload-sles-build-only](https://lab.llvm.org/buildbot/#/builders/285/builds/758) - emailed, @jplehr

* [ ]  [clang-m68k-linux-cross](https://lab.llvm.org/buildbot/#/builders/192/builds/8866) - @glaubitz

* [ ]  [clang-with-thin-lto-ubuntu](https://lab.llvm.org/buildbot/#/builders/67/builds/15551) - @gkistanova

* [ ]  [clang-with-lto-ubuntu](https://lab.llvm.org/buildbot/#/builders/124/builds/10491) - @gkistanova

Action needed for the people pinged here: Please update the buildbots for which you are listed as a maintainer to Python 3.8 so we can complete the upgrade described in the RFC.

The buildbot is running openSUSE Leap 15.5. Let me see whether I can install Python 3.11 without problems.

@glaubitz
Copy link
Contributor

The buildbot is running openSUSE Leap 15.5. Let me see whether I can install Python 3.11 without problems.

Upgraded the whole machine to openSUSE Tumbleweed now as there was no other way to switch the system's default Python interpreter to 3.8 or newer. Default Python version is 3.11 now.

aniplcc pushed a commit to aniplcc/llvm-project that referenced this issue Apr 21, 2024
This reverts commit 2dfa30d.

This relands commit 0a6c74e.

This patch originally caused a host of buildbot failures due to several
buildbots not having the necessary python version. That was tracked in
issue llvm#83962, and all bots that failed in the first round have now been
updated. This is an attempt to reland the patch to see if it sticks or
if there are a number of long-running bots where this patch will cause
failures.
aniplcc pushed a commit to aniplcc/llvm-project that referenced this issue Apr 21, 2024
…)""

This reverts commit f293118.

This was again causing buildbot failures. llvm#83962 has been updated with the new
failures, notifying the buildbot maintainers that they need to update their
bots.
@boomanaiden154
Copy link
Contributor Author

@gkistanova Do you have updates on when the bots for which you're listed as a maintainer above (clang-with-thin-lto-ubuntu and clang-with-lto-ubuntu) will be updated to Python 3.8?

@boomanaiden154
Copy link
Contributor Author

@gkistanova Bump on this. I'm going to land this on Friday as it's been about two months, these are the last two remaining bots, and checking the build logs they've been broken for weeks now due to unrelated changes.

@gkistanova
Copy link
Contributor

Landing on Friday is fine. I'll update those 2 workers by then. Thanks for waiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Bugs about LLVM infrastructure
Projects
None yet
Development

No branches or pull requests