Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing host id Cortex-A78AE #84450

Closed
sjoerdmeijer opened this issue Mar 8, 2024 · 5 comments · Fixed by #84485
Closed

Missing host id Cortex-A78AE #84450

sjoerdmeijer opened this issue Mar 8, 2024 · 5 comments · Fixed by #84485

Comments

@sjoerdmeijer
Copy link
Collaborator

Cortex-A78AE does not have an host id in llvm/lib/TargetParser/Host.cpp:

   ...
    .Case("0xd0d", "cortex-a77")
    .Case("0xd41", "cortex-a78")
    .Case("0xd47", "cortex-a710")
    .Case("0xd4d", "cortex-a715")
    ...

As a result -mpcu=native doesn't work.

CC: @davemgreen , @pratlucas , @ostannard

@davemgreen
Copy link
Collaborator

@jthackray too, who might be interested.

I'm not sure if this is upstream yet. It would be good to make sure we add host.cpp support when we do.

@jthackray
Copy link
Contributor

Agreed. I'll have a look.

@sjoerdmeijer
Copy link
Collaborator Author

Ah sorry, I now indeed see that there is no -mcpu=cortex-a78ae support upstream yet. I was assuming that was already in place. Anyway, thanks for taking a look!

@sjoerdmeijer
Copy link
Collaborator Author

And please feel free to close this issue if this is going to be part of your upstreaming effort.

jthackray added a commit to jthackray/llvm-project that referenced this issue Mar 8, 2024
Add support for Arm Cortex A78AE CPU

Technical Reference Manual for Arm Cortex A78AE:
   https://developer.arm.com/documentation/101779/0003

Fixes llvm#84450
@llvmbot
Copy link
Collaborator

llvmbot commented Mar 8, 2024

@llvm/issue-subscribers-backend-aarch64

Author: Sjoerd Meijer (sjoerdmeijer)

Cortex-A78AE does not have an host id in llvm/lib/TargetParser/Host.cpp:
   ...
    .Case("0xd0d", "cortex-a77")
    .Case("0xd41", "cortex-a78")
    .Case("0xd47", "cortex-a710")
    .Case("0xd4d", "cortex-a715")
    ...

As a result -mpcu=native doesn't work.

CC: @davemgreen , @pratlucas , @ostannard

jthackray added a commit that referenced this issue Mar 8, 2024
Add support for Arm Cortex A78AE CPU

Technical Reference Manual for Arm Cortex A78AE:
   https://developer.arm.com/documentation/101779/0003

Fixes #84450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants