Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc] Implement fcntl function #84968

Closed
SchrodingerZhu opened this issue Mar 12, 2024 · 6 comments · Fixed by #89507
Closed

[libc] Implement fcntl function #84968

SchrodingerZhu opened this issue Mar 12, 2024 · 6 comments · Fixed by #89507
Labels
good first issue https://github.com/llvm/llvm-project/contribute libc

Comments

@SchrodingerZhu
Copy link
Contributor

This is currently missing. It is useful when checking fd flags.

@github-actions github-actions bot added the libc label Mar 12, 2024
@nickdesaulniers nickdesaulniers added the good first issue https://github.com/llvm/llvm-project/contribute label Mar 15, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Mar 15, 2024

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. In the comments of the issue, request for it to be assigned to you.
  2. Fix the issue locally.
  3. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  4. Create a Git commit.
  5. Run git clang-format HEAD~1 to format your changes.
  6. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 15, 2024

@llvm/issue-subscribers-good-first-issue

Author: Schrodinger ZHU Yifan (SchrodingerZhu)

This is currently missing. It is useful when checking fd flags.

@l32zhao
Copy link

l32zhao commented Mar 15, 2024

@nickdesaulniers I'd like to work on this.

@SchrodingerZhu
Copy link
Contributor Author

@SchrodingerZhu
Copy link
Contributor Author

You can refer to #84974. It is still a WIP PR, but it shows what files would a syscall wrapper implementation typically involve.

@vinayakdsci
Copy link
Contributor

Hi @l32zhao, are you still working on this? Otherwise I'd be happy to take this issue up. Thanks!

michaelrj-google pushed a commit that referenced this issue May 1, 2024
Fixes #84968. 

Implements the `fcntl()` function defined in the `fcntl.h` header.
@l32zhao l32zhao removed their assignment May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue https://github.com/llvm/llvm-project/contribute libc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants