Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HLSL] Remove Double from pow intrinsic #86181

Closed
farzonl opened this issue Mar 21, 2024 · 5 comments · Fixed by #86407
Closed

[HLSL] Remove Double from pow intrinsic #86181

farzonl opened this issue Mar 21, 2024 · 5 comments · Fixed by #86407
Labels
bug Indicates an unexpected problem or unintended behavior clang:headers Headers provided by Clang, e.g. for intrinsics good first issue https://github.com/llvm/llvm-project/contribute HLSL HLSL Language Support

Comments

@farzonl
Copy link
Member

farzonl commented Mar 21, 2024

We don't have double pow intrinsics in dxc:
https://godbolt.org/z/P4c8dKvcG

code to be removed:
https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/hlsl/hlsl_intrinsics.h#L1177C1-L1184C31

The change will also need to remove the accompanying tests.

@farzonl farzonl added bug Indicates an unexpected problem or unintended behavior good first issue https://github.com/llvm/llvm-project/contribute HLSL HLSL Language Support labels Mar 21, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Mar 21, 2024

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. In the comments of the issue, request for it to be assigned to you.
  2. Fix the issue locally.
  3. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  4. Create a Git commit.
  5. Run git clang-format HEAD~1 to format your changes.
  6. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 21, 2024

@llvm/issue-subscribers-good-first-issue

Author: Farzon Lotfi (farzonl)

We don't have double pow intrinsics in dxc: https://godbolt.org/z/P4c8dKvcG

code to be removed:
https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/hlsl/hlsl_intrinsics.h#L1177C1-L1184C31

The change will also need to remove the accompanying tests.

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 21, 2024

@llvm/issue-subscribers-bug

Author: Farzon Lotfi (farzonl)

We don't have double pow intrinsics in dxc: https://godbolt.org/z/P4c8dKvcG

code to be removed:
https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/hlsl/hlsl_intrinsics.h#L1177C1-L1184C31

The change will also need to remove the accompanying tests.

@farzonl farzonl changed the title Remove Double from pow intrinsic [HLSL] Remove Double from pow intrinsic Mar 21, 2024
@akwotom
Copy link

akwotom commented Mar 21, 2024

Hello @farzonl, I would love to give this a try.
Can you please explain the issue in a different way to aid my understanding?
Thank you.

@shashu8660
Copy link

hello @farzonl i would like to work with this issue parallel with @akwotom

farzonl pushed a commit that referenced this issue Mar 25, 2024
Currently, the HLSL community is re-implementing its HLSL compiler, the
DirectX Shader Compiler (DXC), in LLVM/main piece by piece. This change
removes the pow intrinsics with parameters of type double as it is not
available in DXC.

Introduced in
df5137e.

Documentation for HLSL pow function is available here:
https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-pow#parameters

Closes #86181
@EugeneZelenko EugeneZelenko added the clang:headers Headers provided by Clang, e.g. for intrinsics label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior clang:headers Headers provided by Clang, e.g. for intrinsics good first issue https://github.com/llvm/llvm-project/contribute HLSL HLSL Language Support
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants