-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HLSL] Remove Double from pow intrinsic #86181
Comments
Hi! This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:
If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below. |
@llvm/issue-subscribers-good-first-issue Author: Farzon Lotfi (farzonl)
We don't have double pow intrinsics in dxc:
https://godbolt.org/z/P4c8dKvcG
code to be removed: The change will also need to remove the accompanying tests. |
@llvm/issue-subscribers-bug Author: Farzon Lotfi (farzonl)
We don't have double pow intrinsics in dxc:
https://godbolt.org/z/P4c8dKvcG
code to be removed: The change will also need to remove the accompanying tests. |
Hello @farzonl, I would love to give this a try. |
Currently, the HLSL community is re-implementing its HLSL compiler, the DirectX Shader Compiler (DXC), in LLVM/main piece by piece. This change removes the pow intrinsics with parameters of type double as it is not available in DXC. Introduced in df5137e. Documentation for HLSL pow function is available here: https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-pow#parameters Closes #86181
We don't have double pow intrinsics in dxc:
https://godbolt.org/z/P4c8dKvcG
code to be removed:
https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/hlsl/hlsl_intrinsics.h#L1177C1-L1184C31
The change will also need to remove the accompanying tests.
The text was updated successfully, but these errors were encountered: