Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offload: cryptic error message when -DLLVM_LIBC_GPU_BUILD=ON is not set #90708

Closed
sylvestre opened this issue May 1, 2024 · 3 comments · Fixed by #90729
Closed

offload: cryptic error message when -DLLVM_LIBC_GPU_BUILD=ON is not set #90708

sylvestre opened this issue May 1, 2024 · 3 comments · Fixed by #90729
Labels
cmake Build system in general and CMake in particular offload

Comments

@sylvestre
Copy link
Collaborator

with

cmake -S ../llvm/ -B build-llvm \
-G Ninja \
-DCMAKE_INSTALL_PREFIX=/usr/lib/llvm-19 \
-DLLVM_VERSION_SUFFIX= \
-DCMAKE_SUPPRESS_REGENERATION=ON \
-DCMAKE_BUILD_TYPE=Release \
-DPACKAGE_VENDOR=Debian \
-DENABLE_LINKER_BUILD_ID=ON \
-DLLVM_TARGETS_TO_BUILD=Native \
-DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;lld;cross-project-tests;mlir;bolt;flang;polly;openmp;lldb" \
-DLLVM_ENABLE_RUNTIMES="compiler-rt;libcxx;libcxxabi;libc;libunwind;offload" \
-DLLVM_ENABLE_PIC=ON \
-DLLVM_ENABLE_RTTI=ON \
-DLLVM_BUILD_DOCS=OFF \
-DLLVM_INCLUDE_GO_TESTS=OFF \
-DLLVM_USE_RELATIVE_PATHS_IN_FILES=ON \
-DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON \
-DLLVM_ENABLE_CURL=ON \
-DLLVM_USE_RELATIVE_PATHS_IN_DEBUG_INFO=ON \
-DCLANG_PLUGIN_SUPPORT=OFF \
-DCLANG_BUILD_EXAMPLES=OFF \
-DCLANG_DEFAULT_LINKER=ld \
-DCLANG_DEFAULT_RTLIB=libgcc \
-DCOMPILER_RT_BUILD_XRAY=OFF \
-DCOMPILER_RT_INCLUDE_TESTS=OFF \
-DCOMPILER_RT_USE_LIBCXX=OFF \
-DCOMPILER_RT_USE_BUILTINS_LIBRARY=ON \
-DLIBUNWIND_INSTALL_LIBRARY=OFF \
-DOPENMP_ENABLE_LIBOMP_PROFILING=OFF \
-DOPENMP_ENABLE_LIBOMPTARGET_PROFILING=OFF \
-DLIBOMP_ENABLE_RTTI=OFF \
-DLIBOMP_OMPT_SUPPORT=OFF \
-DCLANG_FORCE_MATCHING_LIBCLANG_SOVERSION=ON \
-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF \
 -DLLVM_USE_LINKER=gold -DLLVM_BINUTILS_INCDIR=/usr/include/ -DLIBCXXABI_USE_LLVM_UNWINDER=ON -DLIBOMP_LIBFLAGS="-lm" -DOPENMP_USE_LLVM_UNWINDER=ON  \
-DCLANG_ENABLE_BOOTSTRAP=ON

and

cmake --build build-llvm -j 13 --target stage2

The second stage fails with:


-- Performing Test HAVE_FFI_CALL - Success
-- OMPT target disabled
-- OpenMP tools dir in libomptarget:
CMake Error at /home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-project/offload/plugins-nextgen/common/CMakeLists.txt:31 (if):
  if given arguments:

    "TARGET" "llvmlibc_rpc_server" "AND"

  Unknown arguments specified


-- Configuring incomplete, errors occurred!

passing -DLLVM_LIBC_GPU_BUILD=ON removes the error message

@jdoerfert @jhuber6 rings a bell ?

@sylvestre sylvestre added cmake Build system in general and CMake in particular openmp build-problem offload labels May 1, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented May 1, 2024

@llvm/issue-subscribers-openmp

Author: Sylvestre Ledru (sylvestre)

with ``` cmake -S ../llvm/ -B build-llvm \ -G Ninja \ -DCMAKE_INSTALL_PREFIX=/usr/lib/llvm-19 \ -DLLVM_VERSION_SUFFIX= \ -DCMAKE_SUPPRESS_REGENERATION=ON \ -DCMAKE_BUILD_TYPE=Release \ -DPACKAGE_VENDOR=Debian \ -DENABLE_LINKER_BUILD_ID=ON \ -DLLVM_TARGETS_TO_BUILD=Native \ -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;lld;cross-project-tests;mlir;bolt;flang;polly;openmp;lldb" \ -DLLVM_ENABLE_RUNTIMES="compiler-rt;libcxx;libcxxabi;libc;libunwind;offload" \ -DLLVM_ENABLE_PIC=ON \ -DLLVM_ENABLE_RTTI=ON \ -DLLVM_BUILD_DOCS=OFF \ -DLLVM_INCLUDE_GO_TESTS=OFF \ -DLLVM_USE_RELATIVE_PATHS_IN_FILES=ON \ -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON \ -DLLVM_ENABLE_CURL=ON \ -DLLVM_USE_RELATIVE_PATHS_IN_DEBUG_INFO=ON \ -DCLANG_PLUGIN_SUPPORT=OFF \ -DCLANG_BUILD_EXAMPLES=OFF \ -DCLANG_DEFAULT_LINKER=ld \ -DCLANG_DEFAULT_RTLIB=libgcc \ -DCOMPILER_RT_BUILD_XRAY=OFF \ -DCOMPILER_RT_INCLUDE_TESTS=OFF \ -DCOMPILER_RT_USE_LIBCXX=OFF \ -DCOMPILER_RT_USE_BUILTINS_LIBRARY=ON \ -DLIBUNWIND_INSTALL_LIBRARY=OFF \ -DOPENMP_ENABLE_LIBOMP_PROFILING=OFF \ -DOPENMP_ENABLE_LIBOMPTARGET_PROFILING=OFF \ -DLIBOMP_ENABLE_RTTI=OFF \ -DLIBOMP_OMPT_SUPPORT=OFF \ -DCLANG_FORCE_MATCHING_LIBCLANG_SOVERSION=ON \ -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF \ -DLLVM_USE_LINKER=gold -DLLVM_BINUTILS_INCDIR=/usr/include/ -DLIBCXXABI_USE_LLVM_UNWINDER=ON -DLIBOMP_LIBFLAGS="-lm" -DOPENMP_USE_LLVM_UNWINDER=ON \ -DCLANG_ENABLE_BOOTSTRAP=ON ```

and

cmake --build build-llvm -j 13 --target stage2

The second stage fails with:


-- Performing Test HAVE_FFI_CALL - Success
-- OMPT target disabled
-- OpenMP tools dir in libomptarget:
CMake Error at /home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-project/offload/plugins-nextgen/common/CMakeLists.txt:31 (if):
  if given arguments:

    "TARGET" "llvmlibc_rpc_server" "AND"

  Unknown arguments specified


-- Configuring incomplete, errors occurred!

passing -DLLVM_LIBC_GPU_BUILD=ON removes the error message

@jdoerfert @jhuber6 rings a bell ?

@llvmbot
Copy link
Collaborator

llvmbot commented May 1, 2024

@llvm/issue-subscribers-offload

Author: Sylvestre Ledru (sylvestre)

with ``` cmake -S ../llvm/ -B build-llvm \ -G Ninja \ -DCMAKE_INSTALL_PREFIX=/usr/lib/llvm-19 \ -DLLVM_VERSION_SUFFIX= \ -DCMAKE_SUPPRESS_REGENERATION=ON \ -DCMAKE_BUILD_TYPE=Release \ -DPACKAGE_VENDOR=Debian \ -DENABLE_LINKER_BUILD_ID=ON \ -DLLVM_TARGETS_TO_BUILD=Native \ -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;lld;cross-project-tests;mlir;bolt;flang;polly;openmp;lldb" \ -DLLVM_ENABLE_RUNTIMES="compiler-rt;libcxx;libcxxabi;libc;libunwind;offload" \ -DLLVM_ENABLE_PIC=ON \ -DLLVM_ENABLE_RTTI=ON \ -DLLVM_BUILD_DOCS=OFF \ -DLLVM_INCLUDE_GO_TESTS=OFF \ -DLLVM_USE_RELATIVE_PATHS_IN_FILES=ON \ -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON \ -DLLVM_ENABLE_CURL=ON \ -DLLVM_USE_RELATIVE_PATHS_IN_DEBUG_INFO=ON \ -DCLANG_PLUGIN_SUPPORT=OFF \ -DCLANG_BUILD_EXAMPLES=OFF \ -DCLANG_DEFAULT_LINKER=ld \ -DCLANG_DEFAULT_RTLIB=libgcc \ -DCOMPILER_RT_BUILD_XRAY=OFF \ -DCOMPILER_RT_INCLUDE_TESTS=OFF \ -DCOMPILER_RT_USE_LIBCXX=OFF \ -DCOMPILER_RT_USE_BUILTINS_LIBRARY=ON \ -DLIBUNWIND_INSTALL_LIBRARY=OFF \ -DOPENMP_ENABLE_LIBOMP_PROFILING=OFF \ -DOPENMP_ENABLE_LIBOMPTARGET_PROFILING=OFF \ -DLIBOMP_ENABLE_RTTI=OFF \ -DLIBOMP_OMPT_SUPPORT=OFF \ -DCLANG_FORCE_MATCHING_LIBCLANG_SOVERSION=ON \ -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF \ -DLLVM_USE_LINKER=gold -DLLVM_BINUTILS_INCDIR=/usr/include/ -DLIBCXXABI_USE_LLVM_UNWINDER=ON -DLIBOMP_LIBFLAGS="-lm" -DOPENMP_USE_LLVM_UNWINDER=ON \ -DCLANG_ENABLE_BOOTSTRAP=ON ```

and

cmake --build build-llvm -j 13 --target stage2

The second stage fails with:


-- Performing Test HAVE_FFI_CALL - Success
-- OMPT target disabled
-- OpenMP tools dir in libomptarget:
CMake Error at /home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-project/offload/plugins-nextgen/common/CMakeLists.txt:31 (if):
  if given arguments:

    "TARGET" "llvmlibc_rpc_server" "AND"

  Unknown arguments specified


-- Configuring incomplete, errors occurred!

passing -DLLVM_LIBC_GPU_BUILD=ON removes the error message

@jdoerfert @jhuber6 rings a bell ?

@jhuber6
Copy link
Contributor

jhuber6 commented May 1, 2024

Probably forgot some quotation marks somewhere.

jhuber6 added a commit to jhuber6/llvm-project that referenced this issue May 1, 2024
Summary:
This variable could be unset if not found or when building standalone.
We should check for that and set it to true or false.

Fixes: llvm#90708
jhuber6 added a commit that referenced this issue May 1, 2024
Summary:
This variable could be unset if not found or when building standalone.
We should check for that and set it to true or false.

Fixes: #90708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Build system in general and CMake in particular offload
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants