[libc++] Test GitHub PRs for libc++ patches #63273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SatinWukerORIG
approved these changes
Jun 17, 2023
StepfenShawn
approved these changes
Jun 18, 2023
xgupta
approved these changes
Jun 25, 2023
|
Can I submit a libc++ PR via github? |
VoltrexKeyva
approved these changes
Jun 27, 2023
Not yet, we're working on that! I'm going to lock this issue as I pick this up again and start experimenting with the GH action configuration necessary to make this work. I suggest folks unsubscribe from this PR because this will get quite spammy :) |
ldionne
force-pushed
the
ldionne-z-github-prs
branch
2 times, most recently
from
145df9b
to
7f8cde6
Compare
|
I am waiting for an admin to add the BuildKite API token I provided to the repo :-) |
ldionne
force-pushed
the
ldionne-z-github-prs
branch
18 times, most recently
from
6101137
to
c498911
Compare
ldionne
force-pushed
the
ldionne-z-github-prs
branch
20 times, most recently
from
86f2481
to
e58f9fc
Compare
This basically inlines the logic that was previously located in https://github.com/google/llvm-premerge-checks so it is part of the monorepo. This has the benefit of making it extremely easy for individual projects to understand and modify this logic for their own needs, unlike the current model where this logic lives in a separate non-LLVM repository. It also allows testing changes to the CI configuration using a simple Phabricator review, since the code that defines the CI pipeline is taken from the patch under review. This (or something equivalent) is necessary if we want to retain the current monolithic pre-commit CI throughout the GitHub PR transition. Since triggering the monolithic CI is currently attached to the system we use for triggering CI pipelines from Phabricator, we will lose that part of the CI when we move to GitHub PRs if we don't do anything. I've decided to rewrite the code as a shell script because the logic was fairly simple and it seemed a lot easier than figuring out how to pull only the relevant parts of llvm-premerge-checks into the monorepo. Furthermore, I think we should strive to move away from the monolithic CI altogether since sub-projects should understand, own and maintain the tests that are relevant for them to run in the CI (with LLVM providing the infrastructure). Hence, this is somewhat of a temporary solution until monolithic CI is removed entirely. Differential Revision: https://reviews.llvm.org/D158863
ldionne
force-pushed
the
ldionne-z-github-prs
branch
from
e58f9fc
to
2610bbb
Compare
|
Closing this since cf1a3d9 was merged via Phabricator. CI should work now for PRs but we'll probably need to make some tweaks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.