[llvm-exegesis] Add error handling for fork failures #65186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are still some transient failures on the clang-avx512 builder on the new subprocess memory tests. Some of them seem to be related to an inability to fork, but it's hard to debug currently as there is no explicit error handling for a failed fork call, and nice error reporting for a failed fork is something that we should have regardless.
|
@legrosbuffle @gchatelet This is ready for review when reviewers have a chance. Thanks! |
legrosbuffle
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still some transient failures on the clang-avx512 builder on the new subprocess memory tests. Some of them seem to be related to an inability to fork, but it's hard to debug currently as there is no explicit error handling for a failed fork call, and nice error reporting for a failed fork is something that we should have regardless.