Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang-tidy] readability-identifier-naming - fix StructCase and UnionCase in C #65202

Conversation

PiotrZSL
Copy link
Member

@PiotrZSL PiotrZSL commented Sep 2, 2023

In C struct are visible as RecordDecl, not as CXXRecordDecl, this type of declaration were not supported in this check before. Changing check to support it. Added tests.

Fixes: #55422

…Case in C

In C struct are visible as RecordDecl, not as CXXRecordDecl,
this type of declaration were not supported in this check
before. Changing check to support it. Added tests.

Fixes: llvm#55422
Copy link
Contributor

@carlosgalvezp carlosgalvezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PiotrZSL PiotrZSL merged commit fa8e740 into llvm:main Sep 3, 2023
1 check passed
@PiotrZSL PiotrZSL deleted the 55422-readability-identifier-namingstructcase-not-working-for-c-file branch September 3, 2023 16:40
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
…Case in C (llvm#65202)

In C struct are visible as RecordDecl, not as CXXRecordDecl, this type
of declaration were not supported in this check before. Changing check
to support it. Added tests.

Fixes: llvm#55422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

readability-identifier-naming.StructCase not working for .c file
2 participants