Add regalloc team to CODEOWNERS #65208
Conversation
.github/CODEOWNERS
Outdated
| /llvm/include/CodeGen/RegAlloc* @llvm/pr-subscribers-regalloc | ||
| /llvm/include/CodeGen/*Regalloc* @llvm/pr-subscribers-regalloc | ||
| /llvm/include/CodeGen/Register* @llvm/pr-subscribers-regalloc | ||
| /llvm/include/CodeGen/LiveReg* @llvm/pr-subscribers-regalloc |
There was a problem hiding this comment.
That pulls in some unrelated debug info stuff
.github/CODEOWNERS
Outdated
| @@ -395,6 +395,36 @@ flang/**/CodeGen/ @llvm/pr-subscribers-flang-codegen | |||
| /llvm/utils/TableGen/CodeGenDAG* @llvm/pr-subscribers-selectiondag | |||
| /llvm/utils/TableGen/DAGISel* @llvm/pr-subscribers-selectiondag | |||
|
|
|||
| # register allocation | |||
| /llvm/include/CodeGen/RegAlloc* @llvm/pr-subscribers-regalloc | |||
There was a problem hiding this comment.
Isn't this line caught by the following one?
There was a problem hiding this comment.
I'm pretty sure this is case sensitive, so no. I renamed the offending files so it shouldn't matter anymore
.github/CODEOWNERS
Outdated
| /llvm/include/PBQP/ @llvm/pr-subscribers-regalloc | ||
| /llvm/include/PBQPRAConstraint.h @llvm/pr-subscribers-regalloc | ||
| /llvm/include/llvm/CodeGen/Spiller.h @llvm/pr-subscribers-regalloc | ||
| /llvm/lib/CodeGen/*RegAlloc* @llvm/pr-subscribers-regalloc |
There was a problem hiding this comment.
Wouldn't llvm/**/*RegAlloc be enough to cover include/ and lib/?
(you don't need the trailing *, it seems that .gitignore format matches on prefix from what I gathered)
There was a problem hiding this comment.
I have no idea how to test if this is working or not
There was a problem hiding this comment.
This is what we use for many other patterns in this file :)
But the way I test it is by trying with .gitignore (GitHub claims that they use the same format).
So I modify a file (or create a new path), check that it shows up in git status, then I add the pattern to .gitignore and check that it does not show up in git status output anymore!
Probably missed some cases. We also probably should rename the ML stuff to use a consistent capitalization scheme
Probably missed some cases. We also probably should rename the ML stuff to use a consistent capitalization scheme