-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RISCV] Add more files to .github/CODEOWNERS #65234
Conversation
@llvm/pr-subscribers-riscv |
Or perhaps we should follow the suggestion in https://discourse.llvm.org/t/input-needed-teams-for-pull-request-subscriptions/73116/79? That's effectively what my Herald rule did (though case-insensitive). |
.github/CODEOWNERS
Outdated
/llvm/**/*RISCV* @llvm/pr-subscribers-riscv | ||
/clang/**/*RISCV* @llvm/pr-subscribers-riscv | ||
/clang/include/clang/Basic/riscv_*.td @llvm/pr-subscribers-riscv | ||
/clang/lib/Headers/riscv_* @llvm/pr-subscribers-riscv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to do:
/llvm/**/*RISCV* @llvm/pr-subscribers-riscv | |
/clang/**/*RISCV* @llvm/pr-subscribers-riscv | |
/clang/include/clang/Basic/riscv_*.td @llvm/pr-subscribers-riscv | |
/clang/lib/Headers/riscv_* @llvm/pr-subscribers-riscv | |
/llvm/**/*RISCV* @llvm/pr-subscribers-riscv | |
/llvm/**/*riscv* @llvm/pr-subscribers-riscv | |
/clang/**/*riscv* @llvm/pr-subscribers-riscv | |
/clang/**/*RISCV* @llvm/pr-subscribers-riscv | |
/lld/**/*riscv* @llvm/pr-subscribers-riscv | |
/lld/**/*RISCV* @llvm/pr-subscribers-riscv |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if lld RISC-V should be it's own team? Seems like a much smaller set of interested people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be ok with that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also https://discourse.llvm.org/t/input-needed-teams-for-pull-request-subscriptions/73116/80
There is a difference between “core” backend files and catch-all patterns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaskRay Do you have a suggestion for what "core" for RISC-V should be?
For me personally, This proposed PR is I think definitely an incremental improvement on the current patterns, so I wouldn't be opposed to merging it and moving discussion on the 'ideal' setup to elsewhere. Marking it as LGTM on that basis. |
No description provided.