Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RISCV] Add more files to .github/CODEOWNERS #65234

Merged
merged 5 commits into from
Sep 4, 2023

Conversation

topperc
Copy link
Collaborator

@topperc topperc commented Sep 3, 2023

No description provided.

@topperc
Copy link
Collaborator Author

topperc commented Sep 3, 2023

@llvm/pr-subscribers-riscv

@jrtc27
Copy link
Collaborator

jrtc27 commented Sep 3, 2023

Or perhaps we should follow the suggestion in https://discourse.llvm.org/t/input-needed-teams-for-pull-request-subscriptions/73116/79? That's effectively what my Herald rule did (though case-insensitive).

Comment on lines 497 to 500
/llvm/**/*RISCV* @llvm/pr-subscribers-riscv
/clang/**/*RISCV* @llvm/pr-subscribers-riscv
/clang/include/clang/Basic/riscv_*.td @llvm/pr-subscribers-riscv
/clang/lib/Headers/riscv_* @llvm/pr-subscribers-riscv
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to do:

Suggested change
/llvm/**/*RISCV* @llvm/pr-subscribers-riscv
/clang/**/*RISCV* @llvm/pr-subscribers-riscv
/clang/include/clang/Basic/riscv_*.td @llvm/pr-subscribers-riscv
/clang/lib/Headers/riscv_* @llvm/pr-subscribers-riscv
/llvm/**/*RISCV* @llvm/pr-subscribers-riscv
/llvm/**/*riscv* @llvm/pr-subscribers-riscv
/clang/**/*riscv* @llvm/pr-subscribers-riscv
/clang/**/*RISCV* @llvm/pr-subscribers-riscv
/lld/**/*riscv* @llvm/pr-subscribers-riscv
/lld/**/*RISCV* @llvm/pr-subscribers-riscv

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if lld RISC-V should be it's own team? Seems like a much smaller set of interested people.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be ok with that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also https://discourse.llvm.org/t/input-needed-teams-for-pull-request-subscriptions/73116/80

There is a difference between “core” backend files and catch-all patterns.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaskRay Do you have a suggestion for what "core" for RISC-V should be?

@asb
Copy link
Contributor

asb commented Sep 4, 2023

For me personally, **/*RISCV matches what I want and I'm not sure the volume of e.g. RISC-V specific LLD or LLDB patches is enough to justify splitting it out into separate teams....but it looks like I'm going to be handling labeling of any RISC-V related patches on my email client-side anyway, so my personal preference is even less relevant!

This proposed PR is I think definitely an incremental improvement on the current patterns, so I wouldn't be opposed to merging it and moving discussion on the 'ideal' setup to elsewhere. Marking it as LGTM on that basis.

@topperc topperc merged commit 54d6e95 into llvm:main Sep 4, 2023
1 check passed
@topperc topperc deleted the pr/riscv-codeowners branch September 4, 2023 17:12
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants