Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X86] Add more files to .github/CODEOWNERS #65235

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

topperc
Copy link
Collaborator

@topperc topperc commented Sep 3, 2023

No description provided.

@topperc topperc requested review from RKSimon, phoebewang and LuoYuanke and removed request for LuoYuanke September 3, 2023 20:27
/llvm/lib/Target/X86/ @llvm/pr-subscribers-x86
/llvm/lib/TargetParser/X86 @llvm/pr-subscribers-x86
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add trailing / to directories

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been X86*

@@ -527,12 +527,15 @@ utils/bazel/llvm-project-overlay/libc/** @llvm/pr-subscribers-libc

# x86
/llvm/include/llvm/IR/IntrinsicsX86.td @llvm/pr-subscribers-x86
/llvm/include/llvm/TargetParser/X86* @llvm/pr-subscribers-x86
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/llvm/include/llvm/Support/X86DisassemblerDecoderCommon.h

Copy link
Contributor

@phoebewang phoebewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@topperc topperc merged commit 7dc199d into llvm:main Sep 4, 2023
1 check passed
@topperc topperc deleted the pr/x86-codeowners branch September 4, 2023 02:18
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants