[compiler-rt] Link atomic against builtins #65239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The atomic shared library needs to be linked against builtins. The `add_compiler_rt_runtime` call already has `DEP builtins` but that only ensures that the `builtins` target is built before `clang_rt.atomic` but doesn't link against `clang_rt.builtins`, to do so we need to use `LINK_LIBS clang_rt.builtins`.
petrhosek
added
cmake
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
The atomic shared library needs to be linked against builtins. The `add_compiler_rt_runtime` call already has `DEP builtins` but that only ensures that the `builtins` target is built before `clang_rt.atomic` but doesn't link against `clang_rt.builtins`, to do so we need to use `LINK_LIBS clang_rt.builtins`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The atomic shared library needs to be linked against builtins. The
add_compiler_rt_runtimecall already hasDEP builtinsbut that only ensures that thebuiltinstarget is built beforeclang_rt.atomicbut doesn't link againstclang_rt.builtins, to do so we need to useLINK_LIBS clang_rt.builtins.