[AST] Fix nested name specifiers printing as NamespaceNamespace #65266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens because we print both the kind of the NNS and the kind of decl (when it refers to one). These are always the same string.
philnik777
added
the
clang:frontend
cor3ntin
approved these changes
Sep 4, 2023
| @@ -16,6 +16,7 @@ | |||
| #include "clang/AST/DeclOpenMP.h" | |||
| #include "clang/AST/DeclTemplate.h" | |||
| #include "clang/AST/LocInfoType.h" | |||
| #include "clang/AST/NestedNameSpecifier.h" | |||
There was a problem hiding this comment.
That does not seem necessary
kadircet
approved these changes
Sep 5, 2023
shafik
reviewed
Sep 5, 2023
| dumpBareDeclRef(NNS->getAsNamespace()); | ||
| break; | ||
| case NestedNameSpecifier::NamespaceAlias: | ||
| OS << " NamespaceAlias"; | ||
| OS << " "; // "NamespaceAlias" is printed as the decl kind. |
There was a problem hiding this comment.
I don't see a test that covers this case.
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
…#65266) This happens because we print both the kind of the NNS and the kind of decl (when it refers to one). These are always the same string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens because we print both the kind of the NNS and the kind of
decl (when it refers to one). These are always the same string.