[RISCV] Disable zcmp push/pop for variadic functions. #65302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Surely you can use Zcmp, you just have to do a separate stack adjustment and saving of a0-a7? |
If we don't want to break the concept that the area of register varargs is higher than the area of callee-saves, we should emit cm.push before saving varargs first. Could I just add a TODO for this PR? |
Variadic function needs a save region for variable arguement and the region is possible to be overlaped with the region of zcmp push/pop used.
yetingk
force-pushed
the
zcmp-variadic
branch
from
bc43cf2
to
82209ea
Compare
|
It's bug fix so personally I would like to have this fix and backport to LLVM 17 if possible at this moment. cc @asb |
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
Variadic function needs a save region for variable arguement and the region is possible to be overlaped with the region of zcmp push/pop used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variadic function needs a save region for variable arguement and the region is possible to be overlaped with the region of zcmp push/pop used.