[Github] Improve automatic new issue labelling #65309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch:
* Replace andymckay/labeler which does not appear to be maintained
by github official solution
* Remove the closed issue workflow which was disabled a few years
ago and never fixed.
* Add a few rules to add label based on PR title, hopefully that
can make triaging simpler. If that turns out to be useful,
we can consider adding more rules for backends, etc.
We could technically also pattern match the body of the issue but
I'm concerned about trying to be _too_ clever.
The new system is only triggered on PR open so manual labels
should not be removed.
Full disclosure, this was not tested, not sure how testing
could be done.
|
Full disclosure, this was not tested, not sure how testing could be done. |
Endilll
reviewed
Sep 5, 2023
There was a problem hiding this comment.
There are keywords to recognize backends (e.g. AArch64, NVPTX, AMDGPU) and LLVM components (e.g. SelectionDAG, SelectionDAGISel, AsmParser). I think they are worth listing here.
Endilll
approved these changes
Sep 5, 2023
|
@Endilll are you happy adding more rules in a separate commit? |
|
Yes. I'm sorry I haven't read PR description attentively enough before submitting a review. |
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
This patch: * Replaces `andymckay/labeler` which does not appear to be maintained by github official solution * Removes the closed issue workflow which was disabled a few years ago and never fixed. * Adds a few rules to add label based on PR title, hopefully that can make triaging simpler. If that turns out to be useful, we can consider adding more rules for backends, etc. We could technically also pattern match the body of the issue but I'm concerned about trying to be _too_ clever. The new system is only triggered on PR open so manual labels should not be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
andymckay/labelerwhich does not appear to be maintained by github official solutionThe new system is only triggered on PR open so manual labels should not be removed.