[Flang][Parser] Refactor parse tree enumerations into common header #65339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch moves all `ENUM_CLASS` definitions from `flang/Parser/parse-tree.h` to `flang/Common/Fortran.h` so they can be used without including the much larger header defining all parse tree nodes.
github-actions
bot
added
the
flang
|
Many of these types were nested within struct/class definitions, and moving them out of those struct/class definitions and into another file is just doing to make them harder to find. Do not do this. This restructuring only makes sense for enumerations that are needed both in parse tree definitions and in the symbol table. |
|
I see, I guess I misunderstood your comment there. I'll close this PR then, and just move a single definition as part of the other patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves all
ENUM_CLASSdefinitions fromflang/Parser/parse-tree.htoflang/Common/Fortran.hso they can be used without including the much larger header defining all parse tree nodes. This is to address a suggestion to patch D157983.These enumerations have been renamed, since they are now placed in a more top-level namespace rather than inside of parse tree node classes, so I would be looking for reviewers to also make sure that these names make sense and to propose any changes to improve them.