Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add example of making a PR with git and GitHub web interface #65393

Merged
merged 7 commits into from
Sep 7, 2023

Conversation

michaelmaitland
Copy link
Contributor

Some people may not have access to gh or may prefer to use git and the GitHub web interface to make a PR. This patch adds an example of making a PR using this approach.

Some people may not have access to `gh` or may prefer to use `git` and
the GitHub web interface to make a PR. This patch adds an example of
making a PR using this approach.
llvm/docs/GitHub.rst Show resolved Hide resolved
llvm/docs/GitHub.rst Outdated Show resolved Hide resolved
llvm/docs/GitHub.rst Show resolved Hide resolved
llvm/docs/GitHub.rst Outdated Show resolved Hide resolved
llvm/docs/GitHub.rst Outdated Show resolved Hide resolved
llvm/docs/GitHub.rst Outdated Show resolved Hide resolved
llvm/docs/GitHub.rst Outdated Show resolved Hide resolved
llvm/docs/GitHub.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@joker-eph joker-eph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@tru tru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! LGTM

llvm/docs/GitHub.rst Outdated Show resolved Hide resolved
ninja check

# Push the rebased changes to your fork.
git push origin my_change
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires -f here because you rebased.

@michaelmaitland michaelmaitland merged commit 93cc72b into llvm:main Sep 7, 2023
1 of 2 checks passed
@michaelmaitland michaelmaitland deleted the making-a-pr-with-git branch September 7, 2023 14:03
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
…lvm#65393)

Some people may not have access to `gh` or may prefer to use `git` and
the GitHub web interface to make a PR. This patch adds an example of
making a PR using this approach.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation infrastructure Bugs about LLVM infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants