[SystemZ][z/OS] This change adds support for the PPA2 section in zOS #65407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
clang:driver
ysyeda
force-pushed
the
ppa2-zos
branch
2 times, most recently
from
f7968e4
to
392fe73
Compare
|
SystemZ back-end changes LGTM. Additional reviews as to the Clang and time support changes would be appreciated. |
|
ping |
MaskRay
requested changes
Sep 20, 2023
| // .byte (i.e., the one for the 3) would, it seems, also match | ||
| // the .byte line below for the 34. | ||
|
|
||
| // RUN: %clang --target=s390x-ibm-zos -xc -S -o - %s | FileCheck %s --check-prefix CHECK-C |
There was a problem hiding this comment.
Use %clang_cc1 in non-driver tests
| @@ -33,13 +33,33 @@ namespace sys { | |||
| template <typename D = std::chrono::nanoseconds> | |||
| using TimePoint = std::chrono::time_point<std::chrono::system_clock, D>; | |||
|
|
|||
| // utc_clock and utc_time are only available since C++20. Add enough code to | |||
| // support formatting date/time in UTC. | |||
| class UtcClock : public std::chrono::system_clock {}; | |||
There was a problem hiding this comment.
This Support change needs to be split from this patch with a unittest in llvm/unittest/Support.
Many people will think this z/OS patch is unrelated to them.
There was a problem hiding this comment.
I created a new PR for the UTC clock changes here: #67846
MaskRay
reviewed
Sep 20, 2023
| @@ -43,6 +43,7 @@ enum class Language : uint8_t { | |||
| HLSL, | |||
| ///@} | |||
| }; | |||
| const char *LanguageToString(Language L); | |||
There was a problem hiding this comment.
languageToString? This file correctly uses functionName unlike many other Clang files...
|
Breaking this PR into 2 for chrono.h/.cpp changes and for zOS specific changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the PPA2 fields.