[OpenMP] Fix issue of indirect function call in __kmpc_fork_call_if
#65436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The outlined function is typically invoked by using `__kmp_invoke_microtask`, which is written in asm. D138495 introduces a new interface function for parallel region for OpenMPIRBuilder, where the outlined function is called via the function pointer. For some reason, it works perfectly well on x86 and x86-64 system, but doesn't work on aarch64. The 3rd argument in the callee is always `nullptr`, even if it is not in caller. It appears `x2` always contains `0x0`. This patch adopts the typical method to invoke the function pointer. It works on my M2 Ultra Mac. Fix llvm#63194.
jdoerfert
approved these changes
Sep 6, 2023
DavidTruby
approved these changes
Sep 6, 2023
DavidTruby
reviewed
Sep 6, 2023
|
Seeing the following compilation errors with this change: Can be fixed by replacing the added #ifdef OMPT_SUPPORT with #if OMPT_SUPPORT: |
Yeah, thanks for that. Fixed. |
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
…llvm#65436) The outlined function is typically invoked by using `__kmp_invoke_microtask`, which is written in asm. D138495 introduces a new interface function for parallel region for OpenMPIRBuilder, where the outlined function is called via the function pointer. For some reason, it works perfectly well on x86 and x86-64 system, but doesn't work on Apple Silicon. The 3rd argument in the callee is always `nullptr`, even if it is not in caller. It appears `x2` always contains `0x0`. This patch adopts the typical method to invoke the function pointer. It works on my M2 Ultra Mac. Fix llvm#63194.
chandankds
reviewed
Dec 17, 2023
| __kmp_invoke_microtask(VOLATILE_CAST(microtask_t) microtask, gtid, | ||
| /*npr=*/0, | ||
| /*argc=*/0, | ||
| /*args=*/nullptr |
There was a problem hiding this comment.
@shiltian This null pointer is causing segmentation fault in one of the flang test. I am new to Openmp runtimes, Could you please share what was the intention behind using nullptr here and can it be replaced with &args ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outlined function is typically invoked by using
__kmp_invoke_microtask,which is written in asm. D138495 introduces a new interface function for parallel
region for OpenMPIRBuilder, where the outlined function is called via the function
pointer. For some reason, it works perfectly well on x86 and x86-64 system, but
doesn't work on Apple Silicon. The 3rd argument in the callee is always
nullptr, evenif it is not in caller. It appears
x2always contains0x0. This patch adoptsthe typical method to invoke the function pointer. It works on my M2 Ultra Mac.
Fix #63194.