[X86][Driver] Move mno-gather/mno-scatter from m_x86_Features_Group to m_Group. NFCI #65457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o m_Group. NFCI m_x86_Features_Group always turn `mno-xxxx` into `-target-feature-xxxx`. In this case, we don't have `-gather/-scatter` but `+prefer-no-gather/scatter`.
github-actions
bot
added
the
clang:driver
XinWang10
approved these changes
Sep 6, 2023
phoebewang
changed the title
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
…o m_Group. NFCI (llvm#65457) m_x86_Features_Group always turn `mno-xxxx` into `-target-feature -xxxx`. In this case, we don't have `-gather/-scatter` but `+prefer-no-gather/scatter`. This patch solves unexpected warning when using `mno-gather/mno-scatter`: ``` '-gather' is not a recognized feature for this target (ignoring feature) '-scatter' is not a recognized feature for this target (ignoring feature) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m_x86_Features_Group always turn
mno-xxxxinto-target-feature -xxxx. In this case, we don't have-gather/-scatterbut+prefer-no-gather/scatter.This patch solves unexpected warning when using
mno-gather/mno-scatter: