Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc] customizable namespace 2/4 #65471

Merged
merged 1 commit into from
Sep 7, 2023
Merged

[libc] customizable namespace 2/4 #65471

merged 1 commit into from
Sep 7, 2023

Conversation

gchatelet
Copy link
Contributor

@gchatelet gchatelet added the libc label Sep 6, 2023
@gchatelet gchatelet requested a review from a team as a code owner September 6, 2023 13:00
@gchatelet
Copy link
Contributor Author

The build was broken yesterday but I think the patch is safe to land. Doing now.

@gchatelet gchatelet merged commit 9c4e005 into llvm:main Sep 7, 2023
1 of 2 checks passed
@gchatelet gchatelet deleted the custom_namespace branch September 7, 2023 15:19
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
@gchatelet @avillega
[libc] customizable namespace 2/4 (llvm#65471)
a5416cc 
This implements the second step of
https://discourse.llvm.org/t/rfc-customizable-namespace-to-allow-testing-the-libc-when-the-system-libc-is-also-llvms-libc/73079

Namely "Add a guard in `src/__support/common.h`"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivachandra sivachandra sivachandra approved these changes

@lntue lntue lntue approved these changes

Assignees
No one assigned
Labels
libc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gchatelet @sivachandra @lntue