Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Driver] Wrap -lgcc_s in -z ignore/-z record on Solaris #65487

Merged
merged 1 commit into from
Sep 6, 2023
Merged

[Driver] Wrap -lgcc_s in -z ignore/-z record on Solaris #65487

merged 1 commit into from
Sep 6, 2023

Conversation

rorth
Copy link
Collaborator

@rorth rorth commented Sep 6, 2023

clang currently links libgcc_s unconditionally on Solaris, which is unnecessary.

This patch wraps it in -z ignore/-z record instead.

Tested on amd64-pc-solaris2.11 and x86_64-pc-linux-gnu.

@rorth
[Driver] Wrap -lgcc_s in -z ignore/-z record on Solaris
4693f4a 
`clang` currently links `libgcc_s` unconditionally on Solaris, which is
unnecessary.

This patch wraps it in `-z ignore`/`-z record` instead.

Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`.
@rorth rorth requested a review from MaskRay September 6, 2023 14:32
@rorth rorth requested a review from a team as a code owner September 6, 2023 14:32
@github-actions github-actions bot added the clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' label Sep 6, 2023
@MaskRay
Copy link
Member

MaskRay commented Sep 6, 2023

@tstellar Strangely, pr-subscribers-clang-driver is not added for this PR.

% echo '/clang/*/Driver/' >> .gitignore
% git check-ignore -v --no-index clang/lib/Driver/Driver.cpp
.gitignore:74:/clang/*/Driver/  clang/lib/Driver/Driver.cpp
% git restore .gitignore

We can see that the pattern in .github/CODEOWNERS can match clang/lib/Driver/ files.

@rorth rorth merged commit b084d10 into llvm:main Sep 6, 2023
1 of 2 checks passed
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
@rorth
[Driver] Wrap -lgcc_s in -z ignore/-z record on Solaris (llvm#65487)
b8332e2 
`clang` currently links `libgcc_s` unconditionally on Solaris, which is
unnecessary.

This patch wraps it in `-z ignore`/`-z record` instead.

Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaskRay MaskRay MaskRay approved these changes

Assignees
No one assigned
Labels
clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rorth @MaskRay