Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADT] Add detection utility for incomplete types #65495

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

kuhar
Copy link
Member

@kuhar kuhar commented Sep 6, 2023

This allows us to produce better error messages for types that were only forward-declared, but where a full definition was expected.

The first user will be https://reviews.llvm.org/D159013; this change is sent to review separately to reduce the scope of the other patch.

Copy link
Member

@zero9178 zero9178 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % typo

llvm/include/llvm/ADT/STLExtras.h Outdated Show resolved Hide resolved
This allows us to produce better error messages for types that were only
forward-declared, but where a full definiton was expected.

The first user will be https://reviews.llvm.org/D159013.
Copy link
Contributor

@Hardcode84 Hardcode84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuhar kuhar merged commit 2e3d694 into llvm:main Sep 6, 2023
2 checks passed
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
This allows us to produce better error messages for types that were only
forward-declared, but where a full definition was expected.

The first user will be https://reviews.llvm.org/D159013; this change is
sent to review separately to reduce the scope of the other patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants