Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub] Add llvm and bolt PR labels #65509

Closed
wants to merge 1 commit into from
Closed

[GitHub] Add llvm and bolt PR labels #65509

wants to merge 1 commit into from

Conversation

aeubanks
Copy link
Contributor

@aeubanks aeubanks commented Sep 6, 2023

No description provided.

@aeubanks
Copy link
Contributor Author

aeubanks commented Sep 6, 2023

@tstellar the "Files changed" tab should show which teams need creating

@tstellar
Copy link
Collaborator

tstellar commented Sep 9, 2023

Hi, we are making some changes to the notification system. I think some of the paths and labels you requested are already in .github/new-prs-labeler.yml, but if you see something that is missing there could you change this PR to modify that file instead.

Also note that this new file uses minimatch glob parser which is different in some ways from the .gitignore syntax used by the CODEOWNERS file. The main difference is you need to do things like directory/** instead of directory/ to select a directory's contents.


# clang
/clang/ @llvm/pr-subscribers-clang
/clang-tools-extra/ @llvm/pr-subscribers-clang
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I think pr-subscribers-clang should not watch /clang-tools-extra/. We can have a separate team to watch /clang-tools-extra

@aeubanks aeubanks changed the title [GitHub] Add more CODEOWNERS for top level projects [GitHub] Add llvm and bolt PR labels Sep 15, 2023

llvm:
- llvm/**/*

lld:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a pr-subscribers-lld

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a pr-subscribers-lld

I just created it.

@aeubanks aeubanks closed this Nov 14, 2023
@aeubanks aeubanks deleted the gh branch November 14, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants