Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub] Add teams for ADT and Support #65519

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

kuhar
Copy link
Member

@kuhar kuhar commented Sep 6, 2023

No description provided.

Copy link
Contributor

@kazutakahirata kazutakahirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for creating these!

@kuhar
Copy link
Member Author

kuhar commented Sep 7, 2023

@tstellar could you create these to teams in GitHub?

@tstellar
Copy link
Collaborator

tstellar commented Sep 9, 2023

Hi, we are making some changes to the notification system, could you move these paths lists into .github/new-prs-labeler.yml. Use llvm:adt and llvm:support for the label names in the file e.g.

llvm:adt:

  • /path/1
  • /path2/

Also note that this new file uses minimatch glob parser which is different in some ways from the .gitignore syntax used by the CODEOWNERS file. The main difference is you need to do things like directory/** instead of directory/ to select a directory's contents.

@kuhar
Copy link
Member Author

kuhar commented Sep 11, 2023

@tstellar done

@kuhar kuhar force-pushed the codeowners-adt branch 2 times, most recently from e5390c8 to c9c64a2 Compare September 14, 2023 19:18
@kuhar kuhar requested a review from tstellar September 14, 2023 19:19
@kuhar kuhar merged commit 63327fa into llvm:main Sep 15, 2023
2 checks passed
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants