Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb] Allow lldbDataFormatters.py to be used by other names (NFC) #65528

Conversation

kastiglione
Copy link
Contributor

Instead of hard-coding the name lldbDataFormatters, use __name__ to get the module's name.

This allows the formatters to be loaded from any path, with any filename.

Copy link
Contributor

@felipepiovezan felipepiovezan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will save us a lot trouble! :)

@kastiglione kastiglione merged commit a4b82f7 into llvm:main Sep 6, 2023
1 of 2 checks passed
@kastiglione kastiglione deleted the lldb-Allow-lldbDataFormatters.py-to-be-used-by-other-names-NFC branch September 6, 2023 20:40
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
…lvm#65528)

Instead of hard-coding the name `lldbDataFormatters`, use `__name__` to
get the module's name.

This allows the formatters to be loaded from any path, with any
filename.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants