[CMake] Pass doc-related LLVM variables to external projects #65531
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating the configuration arguments for external projects, some of the external-project-specific CMake variables only work in combination with CMake variables from LLVM itself. In particular, the some of the doc-related CMake variables in libcxx depend on LLVM_ENABLE_SPHINX. Pass LLVM_ENABLE_SPHINX LLVM_BUILD_DOCS to external projects. Differential Revision: https://reviews.llvm.org/D158483
|
Migrated here from Phabricator. I hope that this was the right thing to do! Thanks @llvm-beanz and @petrhosek ! |
|
I feel like this isn't something we should do for all external project invocations, just the runtime ones that depend on it. |
|
Okay! I will modify the PR and resubmit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating the configuration arguments for external projects, some of the external-project-specific CMake variables only work in combination with CMake variables from LLVM itself. In particular, the some of the doc-related CMake variables in libcxx depend on LLVM_ENABLE_SPHINX. Pass
LLVM_ENABLE_SPHINX
LLVM_BUILD_DOCS
to external projects.
Differential Revision: https://reviews.llvm.org/D158483