Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RISCV] Added definition of Ventana veyron-v1 processor. #65535

Closed
wants to merge 2 commits into from

Conversation

mgudim
Copy link
Contributor

@mgudim mgudim commented Sep 6, 2023

No description provided.

@mgudim mgudim requested review from a team as code owners September 6, 2023 21:36
@github-actions github-actions bot added backend:RISC-V clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Sep 6, 2023
@mgudim mgudim requested review from topperc and asb September 6, 2023 21:37
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Sep 18, 2023
@michaelmaitland
Copy link
Contributor

Merge branch 'llvm:main' into mgudim_veyron_def

The LLVM GitHub User Guide recommends to rebase on main instead of merge main.

@mgudim
Copy link
Contributor Author

mgudim commented Sep 18, 2023

Merge branch 'llvm:main' into mgudim_veyron_def

The LLVM GitHub User Guide recommends to rebase on main instead of merge main.

Yes, my bad. Still learning the new workflow. I got this merge commit after pressing the "sync" button on my fork. Is there a way to fix this now?

@michaelmaitland
Copy link
Contributor

Is there a way to fix this now?

I think you can drop the merge commit using git rebase -i. You may have to pass --rebase-merges to have the ability to drop the merge commit. Then you can pull upstream and git rebase upstream/main.

@mgudim
Copy link
Contributor Author

mgudim commented Sep 18, 2023

I think you can drop the merge commit using git rebase -i. You may have to pass --rebase-merges to have the ability to drop the merge commit. Then you can pull upstream and git rebase upstream/main.

Thanks Michael, I tried but messed it up (I see more changes than I intended). Let me try again. If I mess it up again, is it OK if I just close this PR and start over?

@michaelmaitland
Copy link
Contributor

michaelmaitland commented Sep 18, 2023

I think you can drop the merge commit using git rebase -i. You may have to pass --rebase-merges to have the ability to drop the merge commit. Then you can pull upstream and git rebase upstream/main.

Thanks Michael, I tried but messed it up (I see more changes than I intended). Let me try again. If I mess it up again, is it OK if I just close this PR and start over?

I think you could drop 5fe9e82 using git rebase -i, recommit it with only the changes you want, and then follow the LLVM GitHub User Guide on how to rebase on main.

But if you want to close this PR and make another PR, thats fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:RISC-V clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants