Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc++] Implement views::join_with #65536

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[libc++] Implement views::join_with #65536

wants to merge 1 commit into from
+5,385 −57

Conversation

JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Sep 6, 2023 •
edited
Loading

@github-actions github-actions bot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Sep 6, 2023
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch 5 times, most recently from 3259db4 to 0481670 Compare September 8, 2023 00:07
@ldionne ldionne assigned var-const and huixie90 and unassigned var-const Sep 13, 2023
@ldionne
Copy link
Member

ldionne commented Sep 15, 2023

@JMazurkiewicz Please ping us when this is ready to review and make it a non-draft.

@philnik777 philnik777 added the ranges Issues related to `<ranges>` label Oct 6, 2023
@JMazurkiewicz JMazurkiewicz mentioned this pull request Oct 24, 2023
Merged
ldionne pushed a commit that referenced this pull request Oct 24, 2023
@JMazurkiewicz
[libc++] Update status of P2770R0, P2441R2 and P2711R1 (#70045)
e1e0598 
This patch adds a mention that the following papers are in progress:

* P2770R0: #66033
* P2441R2 and P2711R1: #65536
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2024 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@JMazurkiewicz JMazurkiewicz marked this pull request as ready for review February 4, 2024 14:58
@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner February 4, 2024 14:58
@H-G-Hristov
Copy link
Contributor

H-G-Hristov commented May 10, 2024 •
edited
Loading

I guess with constexpr variant this cool feature can be finalized now :)

@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch 3 times, most recently from a84985a to fcdf64a Compare May 14, 2024 14:38
@JMazurkiewicz JMazurkiewicz force-pushed the libcxx/ranges/join_with branch 3 times, most recently from 54a741c to a9a1031 Compare May 22, 2024 23:17
@JMazurkiewicz
[libc++] Implement views::join_with
698bdd6 
* Implement "P2441R2 `views::join_with`" (https://wg21.link/P2441R2)
* Complete implementation of "P2711R1 Making multi-param constructors of views explicit" (https://wg21.link/P2711R1)
* Complete implementation of "P2770R0 Stashing stashing iterators for proper flattening" (https://wg21.link/P2770R0)
@Zingam
Copy link
Contributor

Zingam commented Jun 26, 2024

@JMazurkiewicz We have guidelines for applying [[nodiscard]] since recently (in case you missed the discussion). I think you can/ or should/ apply [[nodiscard]] wherever it is relevant now (operators, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zingam Zingam Zingam left review comments

@huixie90 huixie90 Awaiting requested review from huixie90

Assignees

@huixie90 huixie90

Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. ranges Issues related to `<ranges>`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@JMazurkiewicz @ldionne @H-G-Hristov @Zingam @var-const @philnik777 @huixie90