[libc++] Implement views::join_with
#65536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
libc++
JMazurkiewicz
force-pushed
the
libcxx/ranges/join_with
branch
5 times, most recently
from
3259db4
to
0481670
Compare
Zingam
reviewed
Sep 8, 2023
JMazurkiewicz
force-pushed
the
libcxx/ranges/join_with
branch
from
0481670
to
f113229
Compare
|
@JMazurkiewicz Please ping us when this is ready to review and make it a non-draft. |
* Add **experimental** implementation of P2441R2: `views::join_with` (https://wg21.link/P2441R2): * `views::join_with` cannot be used in constant expression because P2231R1 hasn't been implemented * There are some issues with current implementation, see LWG-3971 for example * Feature test macro `__cpp_lib_ranges_join_with` is not defined * Complete implementation of P2711R1: "Making multi-param constructors of views explicit" (https://wg21.link/P2711R1) * Complete implementation of P2770R0: "Stashing stashing iterators for proper flattening" (https://wg21.link/P2770R0)
JMazurkiewicz
force-pushed
the
libcxx/ranges/join_with
branch
from
f113229
to
1835f68
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
views::join_with(https://wg21.link/P2441R2):views::join_withcannot be used in constant expression because P2231R1 hasn't been implemented (work in progress: [libc++] Makeconstexpr std::variant. Implement P2231R1 #83335)__cpp_lib_ranges_join_withis not defined