Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Attributor] Enable AAAddressSpace for OpenMPOpt #65544

Merged
merged 1 commit into from
Sep 7, 2023
Merged

[Attributor] Enable AAAddressSpace for OpenMPOpt #65544

merged 1 commit into from
Sep 7, 2023

Conversation

shiltian
Copy link
Contributor

@shiltian shiltian commented Sep 6, 2023

This patch enables AAAddressSpace for OpenMPOpt, though it only works
for load and store instructions.

@shiltian
[Attributor] Enable AAAddressSpace for OpenMPOpt
a98f6a3 
This patch enables `AAAddressSpace` for OpenMPOpt, though it only works
for load and store instructions.
@shiltian shiltian requested a review from a team as a code owner September 6, 2023 22:48
jdoerfert
jdoerfert approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@jdoerfert jdoerfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@jplehr
Copy link
Contributor

jplehr commented Sep 7, 2023

Will this have an impact on runtime of OpenMPOpt and if so, do we already have an idea of how large that is?

@shiltian
Copy link
Contributor Author

shiltian commented Sep 7, 2023

Will this have an impact on runtime of OpenMPOpt and if so, do we already have an idea of how large that is?

It will not impact the runtime too much because the AA (for now) only depends on AAUnderlyingObjects, which I believe in most cases have already been created regardless.

@shiltian shiltian merged commit e91e3cf into llvm:main Sep 7, 2023
2 checks passed
@shiltian shiltian deleted the as-omp branch September 7, 2023 16:24
@shiltian
Copy link
Contributor Author

shiltian commented Sep 7, 2023

It seems like the revert button here doesn't work…

shiltian added a commit that referenced this pull request Sep 7, 2023
@shiltian
Revert "[Attributor] Enable AAAddressSpace for OpenMPOpt (#65544)"
e592c2d 
This reverts commit e91e3cf because
AMD BB is not happy with it.
@shiltian shiltian restored the as-omp branch September 7, 2023 16:32
shiltian added a commit that referenced this pull request Sep 8, 2023
@shiltian
Reapply "[Attributor] Enable AAAddressSpace for OpenMPOpt (#65544)""
c5525a6 
This reverts commit e592c2d that
reverts e91e3cf.
shiltian added a commit that referenced this pull request Sep 8, 2023
@shiltian
Revert "Reapply "[Attributor] Enable AAAddressSpace for OpenMPOpt (#6…
499f691 
…5544)"""

This reverts commit c5525a6.
AMD BB is not happy again.
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
@shiltian @avillega
[Attributor] Enable AAAddressSpace for OpenMPOpt (llvm#65544)
d022193
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
@shiltian @avillega
Revert "[Attributor] Enable AAAddressSpace for OpenMPOpt (llvm#65544)"
82607f2 
This reverts commit e91e3cf because
AMD BB is not happy with it.
@michaelrj-google michaelrj-google mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdoerfert jdoerfert jdoerfert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shiltian @jplehr @jdoerfert