[mlir][bufferization] Generalize tensor slice rules to subset ops #65619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
mlir:core
matthias-springer
force-pushed
the
subset_op_interface
branch
from
41ff6b3
to
caf328e
Compare
matthias-springer
force-pushed
the
subset_op_interface
branch
from
caf328e
to
593f62a
Compare
maerhart
reviewed
Sep 12, 2023
mlir/include/mlir/Dialect/Bufferization/IR/SubsetOpInterface.td
Outdated
Show resolved
Hide resolved
mlir/include/mlir/Dialect/Bufferization/IR/SubsetOpInterface.td
Outdated
Show resolved
Hide resolved
mlir/include/mlir/Dialect/Bufferization/IR/SubsetOpInterface.td
Outdated
Show resolved
Hide resolved
mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
mlir/include/mlir/Dialect/Bufferization/IR/SubsetOpInterface.td
Outdated
Show resolved
Hide resolved
matthias-springer
force-pushed
the
subset_op_interface
branch
2 times, most recently
from
d14933a
to
952f9ca
Compare
maerhart
reviewed
Sep 13, 2023
| namespace mlir { | ||
| namespace tensor { | ||
| namespace { |
There was a problem hiding this comment.
Why nest an anonymous namespace in mlir/tensor when there is already a using namespace for it?
There was a problem hiding this comment.
To make sure that the function is not visible outside of this file. It's the same as making the functions static.
maerhart
approved these changes
Sep 13, 2023
matthias-springer
force-pushed
the
subset_op_interface
branch
from
952f9ca
to
4e6f145
Compare
This commit generalizes the special tensor.extract_slice/tensor.insert_slice bufferization rules to tensor subset ops. Ops that insert a tensor into a tensor at a specified subset (e.g., tensor.insert_slice, tensor.scatter) can implement the `SubsetOpInterface`. Apart from adding a new op interface (extending the API), this change is NFC. The only ops that currently implement the new interface are tensor.insert_slice and tensor.parallel_insert_slice, and those ops were are supported by One-Shot Bufferize.
matthias-springer
force-pushed
the
subset_op_interface
branch
from
4e6f145
to
5ca4a37
Compare
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…vm#65619) This commit generalizes the special tensor.extract_slice/tensor.insert_slice bufferization rules to tensor subset ops. Ops that insert a tensor into a tensor at a specified subset (e.g., tensor.insert_slice, tensor.scatter) can implement the `SubsetInsertionOpInterface`. Apart from adding a new op interface (extending the API), this change is NFC. The only ops that currently implement the new interface are tensor.insert_slice and tensor.parallel_insert_slice, and those ops were are supported by One-Shot Bufferize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit generalizes the special tensor.extract_slice/tensor.insert_slice bufferization rules to tensor subset ops.
Ops that insert a tensor into a tensor at a specified subset (e.g., tensor.insert_slice, tensor.scatter) can implement the
SubsetInsertionOpInterface.Apart from adding a new op interface (extending the API), this change is NFC. The only ops that currently implement the new interface are tensor.insert_slice and tensor.parallel_insert_slice, and those ops were are supported by One-Shot Bufferize.