Support: allow building with non-C/C++ language linkers #65634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tru
approved these changes
Sep 7, 2023
compnerd
force-pushed
the
linker-options
branch
from
a32d38a
to
5825269
Compare
When building with Swift as the linker language, CMake will use the Swift driver to perform the link oepration. The flags here are not marked to be interpreted by the linker as the default behaviour with MSVC is to use `link` directly rather than through a linker driver. For simplicity's sake and as an immediate solution to these flags being passed to the driver, avoid the delay load with Swift. A more comprehensive solution would be to pass these flags via `-Xlinker` when building with Swift.
compnerd
force-pushed
the
linker-options
branch
from
5825269
to
58b919e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with Swift as the linker language, CMake will use the Swift driver to perform the link oepration. The flags here are not marked to be interpreted by the linker as the default behaviour with MSVC is to use
linkdirectly rather than through a linker driver. For simplicity's sake and as an immediate solution to these flags being passed to the driver, avoid the delay load with Swift. A more comprehensive solution would be to pass these flags via-Xlinkerwhen building with Swift.