cmake: do not force building with the install name dir #65656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tambry
requested changes
Sep 23, 2023
mathstuf
force-pushed
the
no-force-install-name-dir-in-build-tree
branch
2 times, most recently
from
771dc03
to
d498410
Compare
|
Well, I have no idea what CI is choking on… |
Try rebasing. Seems there may have been some CI breakages in master. |
tambry
approved these changes
Sep 24, 2023
mathstuf
force-pushed
the
no-force-install-name-dir-in-build-tree
branch
from
d498410
to
6cb4198
Compare
|
@tambry Thanks for the review. FYI, I do not have merge rights, so someone else will need to hit the button for me. |
|
Could you update the commit message to reflect that it's no longer undocumented? |
When custom install names and rpaths setups are used they may not work in the build tree as-is (namely when using absolute paths for install names in order to avoid rpath juggling in downstream projects). Add a flag for opting out of this behaviour. See: https://reviews.llvm.org/D42463
|
Thanks. Updated. |
mathstuf
force-pushed
the
no-force-install-name-dir-in-build-tree
branch
from
6cb4198
to
a52e378
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When custom install names and rpaths setups are being used, they may not work in the build tree as-is (namely when using absolute paths for install names in order to avoid rpath juggling in downstream projects).
Use an undocumented flag to control this as it is fairly advanced.
See: https://reviews.llvm.org/D42463
I can add docs and a cache entry for this if wanted.