Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RISCV][GISel] Add initial pre-legalizer combiners copying from AArch64. #65663

Closed
wants to merge 1 commit into from

Conversation

topperc
Copy link
Collaborator

@topperc topperc commented Sep 7, 2023

  • [RISCV][GlobalISel] Select ALU GPR instructions
  • [RISCV][GISel] Add initial pre-legalizer combiners copying from AArch64.

This is stack on https://reviews.llvm.org/D76445 to get the RISCVGISel.td and the ability to select basic instructions.

Copy link
Contributor

@aemerson aemerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me from a GISel view, I'll let RISCV maintainers give the approval.

@aemerson
Copy link
Contributor

aemerson commented Sep 8, 2023

However, I just noticed that this is 2 separate commits in a PR. I believe current PR policy is one change per PR, with follow up commits used for addressing review feedback.

@topperc
Copy link
Collaborator Author

topperc commented Sep 8, 2023

However, I just noticed that this is 2 separate commits in a PR. I believe current PR policy is one change per PR, with follow up commits used for addressing review feedback.

It is only because I didn't know how to handle this commit being dependent on another review.

@aemerson
Copy link
Contributor

aemerson commented Sep 8, 2023

However, I just noticed that this is 2 separate commits in a PR. I believe current PR policy is one change per PR, with follow up commits used for addressing review feedback.

It is only because I didn't know how to handle this commit being dependent on another review.

Join the club, we had jackets made.

So far there's no known way to have stacked reviews 🙃

@preames
Copy link
Collaborator

preames commented Sep 11, 2023

LGTM from the RISCV side. Relying heavily on @aemerson previous review for the GISEL bits.

@topperc
Copy link
Collaborator Author

topperc commented Sep 18, 2023

Landed as 8677aaa

@topperc topperc closed this Sep 18, 2023
@topperc topperc deleted the pr/gisel-combine branch September 18, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants