Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the developer policy information on "Stay Informed" to refer to GitHub teams #65798

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

joker-eph
Copy link
Collaborator

No description provided.

If you are doing anything more than just casual work on LLVM, it is suggested that you also
subscribe to the "commits" mailing list for the subproject you're interested in,
Developers should stay informed by reading the `LLVM Discourse forums`_ and subscribing
to the categories of interested for notifications.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/interested/interest/

Paying attention to changes being made by others is a good way to see what other people
are interested in and watching the flow of the project as a whole.

Contibution to the project are made through :ref:`GitHub Pull Requests <github-reviews>`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contributions

are interested in and watching the flow of the project as a whole.

Contibution to the project are made through :ref:`GitHub Pull Requests <github-reviews>`
documentation. You can subscribe to notification for areas of the codebase by joining
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/documentation//. "Contributions are made through documentation" doesn't read right.

@joker-eph
Copy link
Collaborator Author

Thanks @pogo59 ; I fix the issues you found!

Copy link
Collaborator

@pogo59 pogo59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But you might give it a bit more time to see if there are other comments.

@joker-eph
Copy link
Collaborator Author

@tstellar @tru : ping on this documentation udpate?

llvm/docs/DeveloperPolicy.rst Outdated Show resolved Hide resolved
@joker-eph joker-eph merged commit 5f46f21 into llvm:main Sep 12, 2023
1 of 2 checks passed
@joker-eph joker-eph deleted the stay-informed-doc branch September 12, 2023 05:21
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants