Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flang][openacc] Add check for acc cache directive #65807

Merged
merged 1 commit into from
Sep 8, 2023
Merged

[flang][openacc] Add check for acc cache directive #65807

merged 1 commit into from
Sep 8, 2023

Conversation

clementval
Copy link
Contributor

OpenACC 3.3 - 2.10 The cache directive may appear at the top of (inside of) a loop.

This patch adds a semantic check to ensure the cache directive is inside a loop.

@clementval clementval requested a review from a team as a code owner September 8, 2023 21:15
@github-actions github-actions bot added the flang Flang issues not falling into any other category label Sep 8, 2023
vzakhari
vzakhari approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@vzakhari vzakhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clementval clementval merged commit db20592 into llvm:main Sep 8, 2023
1 of 2 checks passed
@clementval clementval deleted the acc_cache_error branch September 8, 2023 21:50
@michaelrj-google michaelrj-google mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzakhari vzakhari vzakhari approved these changes

@razvanlupusoru razvanlupusoru Awaiting requested review from razvanlupusoru

Assignees
No one assigned
Labels
flang Flang issues not falling into any other category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clementval @vzakhari