Improve the pull-request subcription notification format by adding the description and files statistics #65828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #65439 (comment) for a test |
…e description and files statistics
joker-eph
force-pushed
the
pr-subscription-email
branch
from
16458f7
to
ec55412
Compare
tstellar
approved these changes
Sep 9, 2023
| @@ -199,7 +246,6 @@ def extract_commit_hash(arg: str): | |||
|
|
|||
|
|
|||
| class ReleaseWorkflow: | |||
|
|
|||
| CHERRY_PICK_FAILED_LABEL = "release:cherry-pick-failed" | |||
There was a problem hiding this comment.
This is black formatting!
jayfoad
reviewed
Sep 13, 2023
| patch = requests.get(self.pr.diff_url).text | ||
| except: | ||
| patch = "" | ||
| diff_stats += "\n<pre>\n" + patch |
There was a problem hiding this comment.
Hi, I'm seeing this <pre> getting escaped to <pre>, so it no longer has the desired effect and the diff looks horrible in the github web UI. Example: #66188 (comment)
There was a problem hiding this comment.
This was changed in #66037 , I'm not totally sure why
There was a problem hiding this comment.
Fixing in #66322
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.