Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMDGPU: Support llvm.exp10 #65860

Merged
merged 1 commit into from
Dec 2, 2023
Merged

AMDGPU: Support llvm.exp10 #65860

merged 1 commit into from
Dec 2, 2023

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Sep 9, 2023

No description provided.

@arsenm arsenm requested a review from a team as a code owner September 9, 2023 20:32
@arsenm
Copy link
Contributor Author

arsenm commented Oct 4, 2023

ping

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023 •
edited

✅ With the latest revision this PR passed the C/C++ code formatter.

@arsenm
Copy link
Contributor Author

arsenm commented Nov 8, 2023

ping

1 similar comment
@arsenm
Copy link
Contributor Author

arsenm commented Nov 13, 2023

ping

@arsenm
Copy link
Contributor Author

arsenm commented Nov 28, 2023

ping

Sisyph
Sisyph reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Sisyph Sisyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot verify whether that approximation is reasonable, but aside from my one comment it looks good.

llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp Outdated
@@ -349,10 +350,10 @@ AMDGPUTargetLowering::AMDGPUTargetLowering(const TargetMachine &TM,
setOperationAction(ISD::IS_FPCLASS, {MVT::f16, MVT::f32, MVT::f64}, Legal);
else {
setOperationAction(ISD::IS_FPCLASS, {MVT::f32, MVT::f64}, Legal);
setOperationAction({ISD::FLOG2, ISD::FEXP2}, MVT::f16, Custom);
setOperationAction({ISD::FLOG2, ISD::FEXP2, ISD::FEXP10}, MVT::f16, Custom);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like setting FEXP10 for f16 Custom here is redundant with the line below.

Pierre-vh
Pierre-vh approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@Pierre-vh Pierre-vh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we need to add the approximate lowering to GlobalISel as well at some point?

  • run clang-format as well, formatter checks failed

@arsenm
Copy link
Contributor Author

arsenm commented Dec 1, 2023

LGTM, do we need to add the approximate lowering to GlobalISel as well at some point?

  • run clang-format as well, formatter checks failed

I'm ignoring it since it mangles action builder calls badly

@arsenm
Copy link
Contributor Author

arsenm commented Dec 1, 2023

LGTM, do we need to add the approximate lowering to GlobalISel as well at some point?

Both should be implementing the same thing as-is?

@arsenm arsenm merged commit db8b85a into llvm:main Dec 2, 2023
3 checks passed
@arsenm arsenm deleted the amdgpu-exp10 branch December 2, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sisyph Sisyph Sisyph left review comments

@Pierre-vh Pierre-vh Pierre-vh approved these changes

Assignees
No one assigned
Labels
backend:AMDGPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arsenm @Sisyph @Pierre-vh @llvmbot