[GlobalISel] Check for unsupported Windows features on invoke #65864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches what is done on calls, since cc981d2 (extended for another case in 5a751e7). Apply both those cases on invoke just like is done for call. Also update the preexisting comment which was left without update in 5a751e7. This fixes github issue llvm#61941.
|
Ping @efriedma-quic or others |
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…5864) This matches what is done on calls, since cc981d2 (extended for another case in 5a751e7). Apply both those cases on invoke just like is done for call. Also update the preexisting comment which was left without update in 5a751e7. This fixes github issue llvm#61941.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches what is done on calls, since
cc981d2 (extended for another case in 5a751e7).
Apply both those cases on invoke just like is done for call.
Also update the preexisting comment which was left without update in 5a751e7.
This fixes github issue #61941.