Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Driver] Remove duplicate -e on DragonFly #65867

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

brad0
Copy link
Contributor

@brad0 brad0 commented Sep 9, 2023

6228122 was commited, but I noticed one spot was missed in the DragonFly Driver.

6228122 was commited, but I noticed
one spot was missed in the DragonFly Driver.
@brad0 brad0 requested a review from a team as a code owner September 9, 2023 23:31
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Sep 9, 2023
@brad0 brad0 requested a review from MaskRay September 9, 2023 23:32
@llvmbot
Copy link
Collaborator

llvmbot commented Sep 9, 2023

@llvm/pr-subscribers-clang

Changes

6228122 was commited, but I noticed one spot was missed in the DragonFly Driver.

Full diff: https://github.com/llvm/llvm-project/pull/65867.diff

1 Files Affected:

  • (modified) clang/lib/Driver/ToolChains/DragonFly.cpp (+1-1)
diff --git a/clang/lib/Driver/ToolChains/DragonFly.cpp b/clang/lib/Driver/ToolChains/DragonFly.cpp
index 6f46864105e9c0..5406fc2d0cc499 100644
--- a/clang/lib/Driver/ToolChains/DragonFly.cpp
+++ b/clang/lib/Driver/ToolChains/DragonFly.cpp
@@ -117,7 +117,7 @@ void dragonfly::Linker::ConstructJob(Compilation &C, const JobAction &JA,
   }
 
   Args.AddAllArgs(CmdArgs,
-                  {options::OPT_L, options::OPT_T_Group, options::OPT_e});
+                  {options::OPT_L, options::OPT_T_Group});
 
   AddLinkerInputs(getToolChain(), Inputs, Args, CmdArgs, JA);
 

@brad0 brad0 merged commit 00add6e into llvm:main Sep 11, 2023
4 checks passed
@brad0 brad0 deleted the clang_driver_dragonfly_e_flag branch September 12, 2023 00:48
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
6228122 was commited, but I noticed one
spot was missed in the DragonFly Driver.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants