Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Haiku] Don't assume clang was build with libstdc++ as default #65871

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

abrachet
Copy link
Member

This test fails with CLANG_DEFAULT_CXX_STDLIB=libc++

This test fails with `CLANG_DEFAULT_CXX_STDLIB=libc++`
@abrachet abrachet requested a review from a team as a code owner September 10, 2023 03:30
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Sep 10, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Sep 10, 2023

@llvm/pr-subscribers-clang

Changes

This test fails with CLANG_DEFAULT_CXX_STDLIB=libc++

Full diff: https://github.com/llvm/llvm-project/pull/65871.diff

1 Files Affected:

  • (modified) clang/test/Driver/haiku.cpp (+1-1)
diff --git a/clang/test/Driver/haiku.cpp b/clang/test/Driver/haiku.cpp
index f022013d1ef79b..64018e8236b282 100644
--- a/clang/test/Driver/haiku.cpp
+++ b/clang/test/Driver/haiku.cpp
@@ -1,5 +1,5 @@
 // Check the C++ header path (libstdc++)
-// RUN: %clangxx --target=x86_64-unknown-haiku -### %s 2>&1 \
+// RUN: %clangxx --target=x86_64-unknown-haiku --stdlib=libstdc++ -### %s 2>&1 \
 // RUN:   --sysroot=%S/Inputs/haiku_x86_64_tree \
 // RUN:   | FileCheck --check-prefix=CHECK-LIBSTDCXX-HEADER-PATH %s
 // CHECK-LIBSTDCXX-HEADER-PATH: "-internal-isystem" "[[SYSROOT:[^"]+]]/boot/system/develop/headers/c++"

@abrachet abrachet merged commit 33f19a6 into llvm:main Sep 10, 2023
4 checks passed
@abrachet abrachet deleted the fix-haiku branch September 10, 2023 04:00
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
…65871)

This test fails with `CLANG_DEFAULT_CXX_STDLIB=libc++`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants