Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc][bazel] Add CPP tests #65941

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

gchatelet
Copy link
Contributor

This PR adds tests for the src/__support/CPP folder to the bazel build system.

@gchatelet gchatelet requested a review from a team as a code owner September 11, 2023 09:43
@llvmbot llvmbot added the libc label Sep 11, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Sep 11, 2023

@llvm/pr-subscribers-libc

Changes

This PR adds tests for the src/__support/CPP folder to the bazel build system.

--
Full diff: https://github.com/llvm/llvm-project/pull/65941.diff

1 Files Affected:

  • (added) utils/bazel/llvm-project-overlay/libc/test/src/__support/CPP/BUILD.bazel (+112)
diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/__support/CPP/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/__support/CPP/BUILD.bazel
new file mode 100644
index 000000000000000..c74f9821849a7a0
--- /dev/null
+++ b/utils/bazel/llvm-project-overlay/libc/test/src/__support/CPP/BUILD.bazel
@@ -0,0 +1,112 @@
+# This file is licensed under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+# Tests for LLVM libc CPP functions.
+
+package(default_visibility = ["//visibility:public"])
+
+licenses(["notice"])
+
+cc_test(
+    name = "atomic_test",
+    srcs = ["atomic_test.cpp"],
+    deps = [
+        "//libc:__support_cpp_atomic",
+        "//libc:libc_root",
+        "//libc/test/UnitTest:LibcUnitTest",
+    ],
+)
+
+cc_test(
+    name = "bitset_test",
+    srcs = ["bitset_test.cpp"],
+    deps = [
+        "//libc:__support_cpp_bitset",
+        "//libc:libc_root",
+        "//libc/test/UnitTest:LibcUnitTest",
+    ],
+)
+
+cc_test(
+    name = "cstddef_test",
+    srcs = ["cstddef_test.cpp"],
+    deps = [
+        "//libc:__support_cpp_cstddef",
+        "//libc:libc_root",
+        "//libc/test/UnitTest:LibcUnitTest",
+    ],
+)
+
+cc_test(
+    name = "integer_sequence_test",
+    srcs = ["integer_sequence_test.cpp"],
+    deps = [
+        "//libc:__support_cpp_utility",
+        "//libc:libc_root",
+        "//libc/test/UnitTest:LibcUnitTest",
+    ],
+)
+
+cc_test(
+    name = "limits_test",
+    srcs = ["limits_test.cpp"],
+    deps = [
+        "//libc:__support_cpp_limits",
+        "//libc:__support_uint",
+        "//libc:libc_root",
+        "//libc/test/UnitTest:LibcUnitTest",
+    ],
+)
+
+cc_test(
+    name = "optional_test",
+    srcs = ["optional_test.cpp"],
+    deps = [
+        "//libc:__support_cpp_optional",
+        "//libc:libc_root",
+        "//libc/test/UnitTest:LibcUnitTest",
+    ],
+)
+
+cc_test(
+    name = "span_test",
+    srcs = ["span_test.cpp"],
+    deps = [
+        "//libc:__support_cpp_array",
+        "//libc:__support_cpp_span",
+        "//libc:libc_root",
+        "//libc/test/UnitTest:LibcUnitTest",
+    ],
+)
+
+cc_test(
+    name = "stringstream_test",
+    srcs = ["stringstream_test.cpp"],
+    deps = [
+        "//libc:__support_cpp_span",
+        "//libc:__support_cpp_stringstream",
+        "//libc:libc_root",
+        "//libc/test/UnitTest:LibcUnitTest",
+    ],
+)
+
+cc_test(
+    name = "string_test",
+    srcs = ["string_test.cpp"],
+    deps = [
+        "//libc:__support_cpp_string",
+        "//libc:libc_root",
+        "//libc/test/UnitTest:LibcUnitTest",
+    ],
+)
+
+cc_test(
+    name = "stringview_test",
+    srcs = ["stringview_test.cpp"],
+    deps = [
+        "//libc:__support_cpp_string_view",
+        "//libc:libc_root",
+        "//libc/test/UnitTest:LibcUnitTest",
+    ],
+)


# Tests for LLVM libc CPP functions.

package(default_visibility = ["//visibility:public"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] why ? these are tests...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've cargo culted it from the other tests utils/bazel/llvm-project-overlay/libc/test/src/**/BUILD.bazel.
I think this is because of our internal massaging script that tags everything as public on the "internal -> upstream" path. It's probably fixable but I don't want to bother for now :)

@gchatelet gchatelet merged commit 6632882 into llvm:main Sep 11, 2023
3 checks passed
@gchatelet gchatelet deleted the add_cpp_tests_to_bazel branch September 11, 2023 09:52
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
This PR adds tests for the `src/__support/CPP` folder to the bazel build
system.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants