-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GVN] Skip debug instructions in findDominatingValue function #65977
Conversation
!41 = distinct !DISubprogram(name: "x", scope: !1, file: !1, line: 14, type: !42, scopeLine: 14, flags: DIFlagAllCallsDescribed, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition | DISPFlagOptimized, unit: !0, retainedNodes: !45) | ||
!42 = !DISubroutineType(types: !43) | ||
!43 = !{!5} | ||
!45 = !{!46, !47, !48, !49, !50} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove !47, !48, !49 and !50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
I've verified that this solves the problem I reported. Thanks! |
findDominatingValue has a search limit, and when it is reached, optimization is not applied. This patch fixes the issue that this limit also takes into account debug intrinsics, so the result of optimization can depend from the presence of debug info.
744d32d
to
1cab01e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…5977) findDominatingValue has a search limit, and when it is reached, optimization is not applied. This patch fixes the issue that this limit also takes into account debug intrinsics, so the result of optimization can depend from the presence of debug info.
findDominatingValue has a search limit, and when it is reached, optimization is
not applied. This patch fixes the issue that this limit also takes into account
debug intrinsics, so the result of optimization can depend from the presence of
debug info.