Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libc++] P2770R0: "Stashing stashing iterators for proper flattening" #66033
[libc++] P2770R0: "Stashing stashing iterators for proper flattening" #66033
Changes from 1 commit
600a282
743b01d
f601c07
be16b57
181cd85
d11d81c
03454c2
7de9a77
f256e1f
1f00358
d5d0610
3861ffa
0e92781
54c31fc
62fa3a7
aebbbac
ca61a70
024b9e2
857aae1
710398a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this private. I suspect you will need
__get_outer()
to be public (or to do some befriending of a few classes, which would be preferable to making it public).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add tests for these constructors? You removed the test in
libcxx/test/std/ranges/range.adaptors/range.join.view/iterator/ctor.parent.outer.pass.cpp
but I don't think you added any for the new ctors. Note that those are exposition only ctors so the tests could go inlibcxx/test/libcxx/<...>
instead oflibcxx/test/std/<...>
-- or if you prefer you can put them inlibcxx/test/std
but mark them withREQUIRES: stdlib=libc++
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this has been addressed (unless I missed it)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.