[Support] Remove redundant forwarding functions read/write (NFC)

[kazutakahirata]

We don't need these forwarding functions if we add a default template
parameter to their callees.

[dwblaikie]

Change looks good to me.

@ldionne - any idea about the premerge check failure? I can't seem to make sense of it - is it some flake/infrastructure failure, or is it suggesting some actual problem with this patch?

[kazutakahirata]

Thanks for reviewing the patch!

@ldionne - any idea about the premerge check failure? I can't seem to make sense of it - is it some flake/infrastructure failure, or is it suggesting some actual problem with this patch?

It looks like the premerge check is run immediately after a pull request is created, and it never gets updated.

[ldionne]

Change looks good to me.

@ldionne - any idea about the premerge check failure? I can't seem to make sense of it - is it some flake/infrastructure failure, or is it suggesting some actual problem with this patch?

It definitely looks infrastructure-related to me, not an issue with this patch. I'm trying to figure out whether that was a flake here: #66650. Thanks for the heads up.

[ldionne]

Yeah, it looks like a flake because that other PR successfully generated the CI pipeline.

[dwblaikie]

Yeah, it looks like a flake because that other PR successfully generated the CI pipeline.

Thanks for taking a look - anything we can do to look into the flake in more detail? Be great to improve the reliability of this sort of infrastructure.

[ldionne]

Honestly this would be a question for @metaflow , since the buildkite pipeline generation runs on the service machines, which he's in charge of.

[metaflow]

looking on output of pipeline script - it was based on a old revision ci that had a bug. Rebasing to a never revision should have fixed that