[NVPTX][NFC] Use unsigned for all custom printmethods #66069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using a mix of unsigned and signed ints in the various PTX asm printers. All calls from tablgen use a non-negative immediate, so either will work, but when doing arithmetic on the return value from `getNumOperands`, or calling `getOperand`, it makes sense to keep everything unsigned.
ldrumm
force-pushed
the
nvptx-unsigned-print-operand
branch
from
fd1b36e
to
8248388
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a mix of unsigned and signed ints in the various PTX asm printers. All calls from tablgen use a non-negative immediate, so either will work, but when doing arithmetic on the return value from
getNumOperands, or callinggetOperand, it makes sense to keep everything unsigned.