[clang][dataflow] In tests, error out if we didn't find any matching target functions. #66197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
sam-mccall
approved these changes
Sep 13, 2023
…target functions. Before, we were silently letting the test pass, which masks test bugs; for an example, see llvm#66195.
martinboehme
force-pushed
the
piper_export_cl_565014126
branch
from
5a827c9
to
8285300
Compare
kstoimenov
pushed a commit
to kstoimenov/llvm-project
that referenced
this pull request
Sep 14, 2023
…target functions. (llvm#66197) Before, we were silently letting the test pass, which masks test bugs; for an example, see llvm#66195.
This was referenced Sep 14, 2023
copybara-service bot
pushed a commit
to google/crubit
that referenced
this pull request
Sep 18, 2023
Before, it was using `targetNullable()` and `targetNonnull()` as function names, but we only analyze functions called `target()`. Framework change [#66197](llvm/llvm-project#66197) fixes this so that we error out if there is no function called `target()`. This patch renames the functions to `target()` and additionally splits the test apart so there is only one call to `checkDiagnostics()` in each test (which makes it easier to understand what is going on if a test fails). Unfortunately, it turns out that we've regressed on two lines in `ParenTypeInTemplate3` while the test was not testing anything. PiperOrigin-RevId: 566268964 Change-Id: Ifac39e5c157f378740430bd18bbb02f0e51f0cb5
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…target functions. (llvm#66197) Before, we were silently letting the test pass, which masks test bugs; for an example, see llvm#66195.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we were silently letting the test pass, which masks test bugs; for an
example, see #66195.