[Dexter] Fix test failures on greendragon #66299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 37a20cc.
adrian-prantl
approved these changes
Sep 13, 2023
rastogishubham
force-pushed
the
LLVMFixGreenDragon
branch
from
883738f
to
ae83aa6
Compare
The issue with these test failures is that the dSYM was not being found by lldb, which is why setting breakpoints was failing and lldb quit without performing any steps. This change copies the dSYM to the same temp directory that the executeable is copied to.
rastogishubham
force-pushed
the
LLVMFixGreenDragon
branch
from
ae83aa6
to
058842d
Compare
SLTozer
approved these changes
Sep 14, 2023
| @@ -217,6 +218,9 @@ def _run_test(self, test_name): | |||
| """ | |||
| try: | |||
| if self.context.options.binary: | |||
| if platform.system() == 'Darwin' and os.path.exists(self.context.options.binary + '.dSYM'): | |||
There was a problem hiding this comment.
Might be a good idea to add a command line option to manually specify the location of the dsym file, but I'm happy to submit that as an extra patch afterwards.
|
@SLTozer Sounds good, I will merge this because greendragon is unstable, and we are seeing XPASSES, and then we can make the dsym location configurable in a future patch! |
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
The issue with these test failures is that the dSYM was not being found by lldb, which is why setting breakpoints was failing and lldb quit without performing any steps. This change copies the dSYM to the same temp directory that the executable is copied to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with these test failures is that the dSYM was not being found by lldb, which is why setting breakpoints was failing and lldb quit without performing any steps. This change copies the dSYM to the same temp directory that the executable is copied to.