[clang][deps] Implement move-conversion for CowCompilerInvocation
#66301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang ChangesThis avoids doing some work at the end of `makeCommonInvocationForModuleBuild()` (in `ModuleDepCollector.cpp`). -- Full diff: https://github.com//pull/66301.diff1 Files Affected:
diff --git a/clang/include/clang/Frontend/CompilerInvocation.h b/clang/include/clang/Frontend/CompilerInvocation.h
index b79a1a53c150171..45e263e7bc76822 100644
--- a/clang/include/clang/Frontend/CompilerInvocation.h
+++ b/clang/include/clang/Frontend/CompilerInvocation.h
@@ -354,6 +354,9 @@ class CowCompilerInvocation : public CompilerInvocationBase {
deep_copy_assign(X);
}
+ CowCompilerInvocation(CompilerInvocation &&X)
+ : CompilerInvocationBase(std::move(X)) {}
+
// Const getters are inherited from the base class.
/// Mutable getters.
|
benlangmuir
approved these changes
Sep 13, 2023
jansvoboda11
added a commit
to apple/llvm-project
that referenced
this pull request
Sep 13, 2023
…lvm#66301) This avoids making copies at the end of `makeCommonInvocationForModuleBuild()` (in `ModuleDepCollector.cpp`).
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…lvm#66301) This avoids making copies at the end of `makeCommonInvocationForModuleBuild()` (in `ModuleDepCollector.cpp`).
jansvoboda11
added a commit
to apple/llvm-project
that referenced
this pull request
Oct 5, 2023
…lvm#66301) This avoids making copies at the end of `makeCommonInvocationForModuleBuild()` (in `ModuleDepCollector.cpp`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids making copies at the end of
makeCommonInvocationForModuleBuild()(inModuleDepCollector.cpp).