[runtimes] Add CODEOWNERS entries for libc++, libc++abi and libunwind #66416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tstellar Ideally we'd also create |
ldionne
force-pushed
the
review/codeowners-runtimes
branch
from
7308556
to
cba969b
Compare
|
I think this is OK, because it's replicating functionality we had with Phabricator, but I think we should have a Discourse discussion about what else to use this file for. |
|
All 3 teams are added and configured correctly now. |
tstellar
approved these changes
Sep 15, 2023
This ensures that a review from the appropriate teams is requested on PRs that modify files belonging to these projects. Relevant discussion: https://discourse.llvm.org/t/changes-to-pull-request-subscription-system
ldionne
force-pushed
the
review/codeowners-runtimes
branch
from
cba969b
to
b66a36c
Compare
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…llvm#66416) This ensures that a review from the appropriate teams is requested on PRs that modify files belonging to these projects. Relevant discussion: https://discourse.llvm.org/t/changes-to-pull-request-subscription-system
zahiraam
pushed a commit
to tahonermann/llvm-project
that referenced
this pull request
Oct 24, 2023
…llvm#66416) This ensures that a review from the appropriate teams is requested on PRs that modify files belonging to these projects. Relevant discussion: https://discourse.llvm.org/t/changes-to-pull-request-subscription-system
zahiraam
pushed a commit
to tahonermann/llvm-project
that referenced
this pull request
Oct 24, 2023
…llvm#66416) This ensures that a review from the appropriate teams is requested on PRs that modify files belonging to these projects. Relevant discussion: https://discourse.llvm.org/t/changes-to-pull-request-subscription-system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that a review from the appropriate teams is requested on PRs that modify files belonging to these projects.
Relevant discussion: https://discourse.llvm.org/t/changes-to-pull-request-subscription-system